* [PATCH RFC] pmdomain: imx: reject a missing bus power domain
@ 2026-09-11 6:09 Slavin Liu
2026-09-11 15:01 ` Frank Li
0 siblings, 1 reply; 2+ messages in thread
From: Slavin Liu @ 2026-09-11 6:09 UTC (permalink / raw)
To: ulfh, frank.li, s.hauer
Cc: kernel, festevam, linux-pm, imx, linux-arm-kernel, linux-kernel,
bolin.liu
The named-domain attach API may return NULL for an absent name.
Treat that as -ENODEV before publishing bus_power_dev to later unwind
paths, without changing the handling of existing error pointers.
Detected by static analysis and reviewed with AI-assisted source auditing.
Fixes: 2684ac05a8c4 ("soc: imx: add i.MX8M blk-ctrl driver")
Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl")
Assisted-by: LLM
Signed-off-by: Slavin Liu <bolin.liu@seu.edu.cn>
---
drivers/pmdomain/imx/imx8m-blk-ctrl.c | 2 ++
drivers/pmdomain/imx/imx8mp-blk-ctrl.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/pmdomain/imx/imx8m-blk-ctrl.c b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
index 479789009c7f..9653a8ac9a6e 100644
--- a/drivers/pmdomain/imx/imx8m-blk-ctrl.c
+++ b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
@@ -228,6 +228,8 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)
return -ENOMEM;
bc->bus_power_dev = dev_pm_domain_attach_by_name(dev, "bus");
+ if (!bc->bus_power_dev)
+ return dev_err_probe(dev, -ENODEV, "missing bus power domain\n");
if (IS_ERR(bc->bus_power_dev)) {
if (PTR_ERR(bc->bus_power_dev) == -ENODEV)
return dev_err_probe(dev, -EPROBE_DEFER,
diff --git a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c
index d255c20f58e2..e952b4ee75c0 100644
--- a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c
+++ b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c
@@ -655,6 +655,8 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev)
return -ENOMEM;
bc->bus_power_dev = dev_pm_domain_attach_by_name(dev, "bus");
+ if (!bc->bus_power_dev)
+ return dev_err_probe(dev, -ENODEV, "missing bus power domain\n");
if (IS_ERR(bc->bus_power_dev))
return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
"failed to attach bus power domain\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RFC] pmdomain: imx: reject a missing bus power domain
2026-09-11 6:09 [PATCH RFC] pmdomain: imx: reject a missing bus power domain Slavin Liu
@ 2026-09-11 15:01 ` Frank Li
0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-09-11 15:01 UTC (permalink / raw)
To: Slavin Liu
Cc: ulfh, frank.li, s.hauer, kernel, festevam, linux-pm, imx,
linux-arm-kernel, linux-kernel
On Fri, Sep 11, 2026 at 02:09:29PM +0800, Slavin Liu wrote:
Please remove RFC for this kind fix patches.
>
> The named-domain attach API may return NULL for an absent name.
> Treat that as -ENODEV before publishing bus_power_dev to later unwind
> paths, without changing the handling of existing error pointers.
>
> Detected by static analysis and reviewed with AI-assisted source auditing.
>
> Fixes: 2684ac05a8c4 ("soc: imx: add i.MX8M blk-ctrl driver")
> Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl")
> Assisted-by: LLM
> Signed-off-by: Slavin Liu <bolin.liu@seu.edu.cn>
> ---
> drivers/pmdomain/imx/imx8m-blk-ctrl.c | 2 ++
> drivers/pmdomain/imx/imx8mp-blk-ctrl.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/pmdomain/imx/imx8m-blk-ctrl.c b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> index 479789009c7f..9653a8ac9a6e 100644
> --- a/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> +++ b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> @@ -228,6 +228,8 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> bc->bus_power_dev = dev_pm_domain_attach_by_name(dev, "bus");
> + if (!bc->bus_power_dev)
> + return dev_err_probe(dev, -ENODEV, "missing bus power domain\n");
> if (IS_ERR(bc->bus_power_dev)) {
> if (PTR_ERR(bc->bus_power_dev) == -ENODEV)
> return dev_err_probe(dev, -EPROBE_DEFER,
> diff --git a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c
> index d255c20f58e2..e952b4ee75c0 100644
> --- a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c
> +++ b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c
> @@ -655,6 +655,8 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> bc->bus_power_dev = dev_pm_domain_attach_by_name(dev, "bus");
> + if (!bc->bus_power_dev)
> + return dev_err_probe(dev, -ENODEV, "missing bus power domain\n");
> if (IS_ERR(bc->bus_power_dev))
> return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
> "failed to attach bus power domain\n");
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-11 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-11 6:09 [PATCH RFC] pmdomain: imx: reject a missing bus power domain Slavin Liu
2026-09-11 15:01 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox