From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev, Arnd Bergmann <arnd@arndb.de>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, arm@kernel.org
Subject: [soc:board-remove-7.3 182/295] drivers/hwmon/ads7828.c:121 ads7828_probe() warn: if statement not indented
Date: Fri, 11 Sep 2026 15:23:28 +0300 [thread overview]
Message-ID: <202609111050.oiut4oST-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git board-remove-7.3
head: cf983087c51a9c74c3d4d3b353eb811ae5030823
commit: 4df92b98525f08e1eab92a25f5da2045c78403e8 [182/295] hwmon: asd7828: remove pdata based probing
config: arm-randconfig-r071-20260911 (https://download.01.org/0day-ci/archive/20260911/202609111050.oiut4oST-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609111050.oiut4oST-lkp@intel.com/
smatch warnings:
drivers/hwmon/ads7828.c:121 ads7828_probe() warn: if statement not indented
vim +121 drivers/hwmon/ads7828.c
5812f9283e6213 Steve Hardy 2008-01-22 116
a8ddfea09566c3 Sam Povilus 2017-03-29 117 diff_input = of_property_read_bool(dev->of_node,
a8ddfea09566c3 Sam Povilus 2017-03-29 118 "ti,differential-input");
fddb5ceaf901b0 Qingshuang Fu 2026-08-05 119 vref_uv = devm_regulator_get_enable_read_voltage(dev, "vref");
fddb5ceaf901b0 Qingshuang Fu 2026-08-05 120 if (vref_uv < 0) {
fddb5ceaf901b0 Qingshuang Fu 2026-08-05 @121 if (vref_uv != -ENODEV)
fddb5ceaf901b0 Qingshuang Fu 2026-08-05 122 return vref_uv;
Add another tab before the return.
fddb5ceaf901b0 Qingshuang Fu 2026-08-05 123 } else {
a8ddfea09566c3 Sam Povilus 2017-03-29 124 vref_mv = DIV_ROUND_CLOSEST(vref_uv, 1000);
a8ddfea09566c3 Sam Povilus 2017-03-29 125 if (vref_mv < ADS7828_EXT_VREF_MV_MIN ||
a8ddfea09566c3 Sam Povilus 2017-03-29 126 vref_mv > ADS7828_EXT_VREF_MV_MAX)
a8ddfea09566c3 Sam Povilus 2017-03-29 127 return -EINVAL;
a8ddfea09566c3 Sam Povilus 2017-03-29 128 ext_vref = true;
a8ddfea09566c3 Sam Povilus 2017-03-29 129 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-09-11 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 12:23 Dan Carpenter [this message]
2026-09-11 15:48 ` [soc:board-remove-7.3 182/295] drivers/hwmon/ads7828.c:121 ads7828_probe() warn: if statement not indented Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202609111050.oiut4oST-lkp@intel.com \
--to=error27@gmail.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox