[soc:board-remove-7.3 182/295] drivers/hwmon/ads7828.c:121 ads7828_probe() warn: if statement not indented

[soc:board-remove-7.3 182/295] drivers/hwmon/ads7828.c:121 ads7828_probe() warn: if statement not indented

[Dan Carpenter]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git board-remove-7.3
head:   cf983087c51a9c74c3d4d3b353eb811ae5030823
commit: 4df92b98525f08e1eab92a25f5da2045c78403e8 [182/295] hwmon: asd7828: remove pdata based probing
config: arm-randconfig-r071-20260911 (https://download.01.org/0day-ci/archive/20260911/202609111050.oiut4oST-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609111050.oiut4oST-lkp@intel.com/

smatch warnings:
drivers/hwmon/ads7828.c:121 ads7828_probe() warn: if statement not indented

vim +121 drivers/hwmon/ads7828.c

5812f9283e6213 Steve Hardy              2008-01-22  116  
a8ddfea09566c3 Sam Povilus              2017-03-29  117  	diff_input = of_property_read_bool(dev->of_node,
a8ddfea09566c3 Sam Povilus              2017-03-29  118  					   "ti,differential-input");
fddb5ceaf901b0 Qingshuang Fu            2026-08-05  119  	vref_uv = devm_regulator_get_enable_read_voltage(dev, "vref");
fddb5ceaf901b0 Qingshuang Fu            2026-08-05  120  	if (vref_uv < 0) {
fddb5ceaf901b0 Qingshuang Fu            2026-08-05 @121  		if (vref_uv != -ENODEV)
fddb5ceaf901b0 Qingshuang Fu            2026-08-05  122  		return vref_uv;

Add another tab before the return.

fddb5ceaf901b0 Qingshuang Fu            2026-08-05  123  	} else {
a8ddfea09566c3 Sam Povilus              2017-03-29  124  		vref_mv = DIV_ROUND_CLOSEST(vref_uv, 1000);
a8ddfea09566c3 Sam Povilus              2017-03-29  125  		if (vref_mv < ADS7828_EXT_VREF_MV_MIN ||
a8ddfea09566c3 Sam Povilus              2017-03-29  126  		    vref_mv > ADS7828_EXT_VREF_MV_MAX)
a8ddfea09566c3 Sam Povilus              2017-03-29  127  			return -EINVAL;
a8ddfea09566c3 Sam Povilus              2017-03-29  128  		ext_vref = true;
a8ddfea09566c3 Sam Povilus              2017-03-29  129  	}
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [soc:board-remove-7.3 182/295] drivers/hwmon/ads7828.c:121 ads7828_probe() warn: if statement not indented

[Arnd Bergmann]

On Fri, Sep 11, 2026, at 14:23, Dan Carpenter wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git 
> board-remove-7.3
> head:   cf983087c51a9c74c3d4d3b353eb811ae5030823
> commit: 4df92b98525f08e1eab92a25f5da2045c78403e8 [182/295] hwmon: 
> asd7828: remove pdata based probing
> config: arm-randconfig-r071-20260911 
> (https://download.01.org/0day-ci/archive/20260911/202609111050.oiut4oST-lkp@intel.com/config)
> compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 
> 6009708b4367171ccdbf4b5905cb6a803753fe18)
> smatch: v0.5.0-9187-g5189e3fb
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <error27@gmail.com>
> | Closes: https://lore.kernel.org/r/202609111050.oiut4oST-lkp@intel.com/

Fixed now, thanks for the report!

     Arnd