* [PATCH] drm/panel: Fix node reference leak in rpi_touchscreen_probe()
@ 2026-09-16 18:05 Wentao Liang
2026-09-24 13:36 ` neil.armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2026-09-16 18:05 UTC (permalink / raw)
To: airlied
Cc: architt, bcm-kernel-feedback-list, dri-devel, eric,
florian.fainelli, jesszhan0024, linux-arm-kernel, linux-kernel,
linux-rpi-kernel, maarten.lankhorst, mripard, neil.armstrong,
simona, treding, tzimmermann, Wentao Liang, stable
of_graph_get_remote_port() returns a reference to the remote port
node. On the success path that reference is passed to the registered
DSI device and released with it, but if mipi_dsi_device_register_full()
fails the reference is never dropped. Release it on the error path.
Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
index dc4bb8ad9131..c14776561623 100644
--- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
+++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
@@ -428,6 +428,7 @@ static int rpi_touchscreen_probe(struct i2c_client *i2c)
if (IS_ERR(ts->dsi)) {
dev_err(dev, "DSI device registration failed: %ld\n",
PTR_ERR(ts->dsi));
+ of_node_put(info.node);
return PTR_ERR(ts->dsi);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/panel: Fix node reference leak in rpi_touchscreen_probe()
2026-09-16 18:05 [PATCH] drm/panel: Fix node reference leak in rpi_touchscreen_probe() Wentao Liang
@ 2026-09-24 13:36 ` neil.armstrong
0 siblings, 0 replies; 2+ messages in thread
From: neil.armstrong @ 2026-09-24 13:36 UTC (permalink / raw)
To: Wentao Liang, airlied
Cc: architt, bcm-kernel-feedback-list, dri-devel, eric,
florian.fainelli, jesszhan0024, linux-arm-kernel, linux-kernel,
linux-rpi-kernel, maarten.lankhorst, mripard, simona, treding,
tzimmermann, stable
On 9/16/26 20:05, Wentao Liang wrote:
> of_graph_get_remote_port() returns a reference to the remote port
> node. On the success path that reference is passed to the registered
> DSI device and released with it, but if mipi_dsi_device_register_full()
> fails the reference is never dropped. Release it on the error path.
>
> Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> index dc4bb8ad9131..c14776561623 100644
> --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> @@ -428,6 +428,7 @@ static int rpi_touchscreen_probe(struct i2c_client *i2c)
> if (IS_ERR(ts->dsi)) {
> dev_err(dev, "DSI device registration failed: %ld\n",
> PTR_ERR(ts->dsi));
> + of_node_put(info.node);
> return PTR_ERR(ts->dsi);
> }
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-24 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-16 18:05 [PATCH] drm/panel: Fix node reference leak in rpi_touchscreen_probe() Wentao Liang
2026-09-24 13:36 ` neil.armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox