* [PATCH] media: mtk-jpeg: Fix runtime PM leak in mtk_jpegdec_worker()
@ 2026-09-17 10:02 Wentao Liang
2026-09-29 21:00 ` Nicolas Dufresne
2026-09-29 21:01 ` Nicolas Dufresne
0 siblings, 2 replies; 3+ messages in thread
From: Wentao Liang @ 2026-09-17 10:02 UTC (permalink / raw)
To: angelogioacchino.delregno
Cc: bin.liu, hverkuil, irui.wang, kyrie.wu, linux-arm-kernel,
linux-kernel, linux-media, linux-mediatek, matthias.bgg, mchehab,
Wentao Liang, stable
pm_runtime_get_sync() leaves the device's runtime PM usage count
incremented even when it fails. mtk_jpegdec_worker() jumps to
dec_end on that failure, which does not call pm_runtime_put(), so
the reference taken by the failed resume is leaked.
Use pm_runtime_resume_and_get() instead, which drops the reference
again when resuming the device fails.
Fixes: dedc21500334 ("media: mtk-jpegdec: add jpeg decode worker interface")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
index 8c684756d5fc..ed1d5858c942 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
@@ -1732,7 +1732,7 @@ static void mtk_jpegdec_worker(struct work_struct *work)
jpeg_dst_buf->frame_num = ctx->total_frame_num;
mtk_jpegdec_set_hw_param(ctx, hw_id, src_buf, dst_buf);
- ret = pm_runtime_get_sync(comp_jpeg[hw_id]->dev);
+ ret = pm_runtime_resume_and_get(comp_jpeg[hw_id]->dev);
if (ret < 0) {
dev_err(jpeg->dev, "%s : %d, pm_runtime_get_sync fail !!!\n",
__func__, __LINE__);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: mtk-jpeg: Fix runtime PM leak in mtk_jpegdec_worker()
2026-09-17 10:02 [PATCH] media: mtk-jpeg: Fix runtime PM leak in mtk_jpegdec_worker() Wentao Liang
@ 2026-09-29 21:00 ` Nicolas Dufresne
2026-09-29 21:01 ` Nicolas Dufresne
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dufresne @ 2026-09-29 21:00 UTC (permalink / raw)
To: Wentao Liang, angelogioacchino.delregno
Cc: bin.liu, hverkuil, irui.wang, kyrie.wu, linux-arm-kernel,
linux-kernel, linux-media, linux-mediatek, matthias.bgg, mchehab,
stable
[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]
Le jeudi 17 septembre 2026 à 10:02 +0000, Wentao Liang a écrit :
> pm_runtime_get_sync() leaves the device's runtime PM usage count
> incremented even when it fails. mtk_jpegdec_worker() jumps to
> dec_end on that failure, which does not call pm_runtime_put(), so
> the reference taken by the failed resume is leaked.
>
> Use pm_runtime_resume_and_get() instead, which drops the reference
> again when resuming the device fails.
>
> Fixes: dedc21500334 ("media: mtk-jpegdec: add jpeg decode worker interface")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> index 8c684756d5fc..ed1d5858c942 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> @@ -1732,7 +1732,7 @@ static void mtk_jpegdec_worker(struct work_struct *work)
> jpeg_dst_buf->frame_num = ctx->total_frame_num;
>
> mtk_jpegdec_set_hw_param(ctx, hw_id, src_buf, dst_buf);
> - ret = pm_runtime_get_sync(comp_jpeg[hw_id]->dev);
> + ret = pm_runtime_resume_and_get(comp_jpeg[hw_id]->dev);
> if (ret < 0) {
> dev_err(jpeg->dev, "%s : %d, pm_runtime_get_sync fail !!!\n",
> __func__, __LINE__);
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: mtk-jpeg: Fix runtime PM leak in mtk_jpegdec_worker()
2026-09-17 10:02 [PATCH] media: mtk-jpeg: Fix runtime PM leak in mtk_jpegdec_worker() Wentao Liang
2026-09-29 21:00 ` Nicolas Dufresne
@ 2026-09-29 21:01 ` Nicolas Dufresne
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dufresne @ 2026-09-29 21:01 UTC (permalink / raw)
To: Wentao Liang, angelogioacchino.delregno
Cc: bin.liu, hverkuil, irui.wang, kyrie.wu, linux-arm-kernel,
linux-kernel, linux-media, linux-mediatek, matthias.bgg, mchehab,
stable
[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]
Le jeudi 17 septembre 2026 à 10:02 +0000, Wentao Liang a écrit :
> pm_runtime_get_sync() leaves the device's runtime PM usage count
> incremented even when it fails. mtk_jpegdec_worker() jumps to
> dec_end on that failure, which does not call pm_runtime_put(), so
> the reference taken by the failed resume is leaked.
>
> Use pm_runtime_resume_and_get() instead, which drops the reference
> again when resuming the device fails.
>
> Fixes: dedc21500334 ("media: mtk-jpegdec: add jpeg decode worker interface")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> index 8c684756d5fc..ed1d5858c942 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> @@ -1732,7 +1732,7 @@ static void mtk_jpegdec_worker(struct work_struct *work)
> jpeg_dst_buf->frame_num = ctx->total_frame_num;
>
> mtk_jpegdec_set_hw_param(ctx, hw_id, src_buf, dst_buf);
> - ret = pm_runtime_get_sync(comp_jpeg[hw_id]->dev);
> + ret = pm_runtime_resume_and_get(comp_jpeg[hw_id]->dev);
> if (ret < 0) {
> dev_err(jpeg->dev, "%s : %d, pm_runtime_get_sync fail !!!\n",
> __func__, __LINE__);
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-29 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-17 10:02 [PATCH] media: mtk-jpeg: Fix runtime PM leak in mtk_jpegdec_worker() Wentao Liang
2026-09-29 21:00 ` Nicolas Dufresne
2026-09-29 21:01 ` Nicolas Dufresne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox