Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] platform/raspberrypi: Use %p for pointer formatting
@ 2026-09-18 10:44 Sebastian Andrzej Siewior
  0 siblings, 0 replies; only message in thread
From: Sebastian Andrzej Siewior @ 2026-09-18 10:44 UTC (permalink / raw)
  To: linux-rpi-kernel, linux-arm-kernel
  Cc: Florian Fainelli, bcm-kernel-feedback-list

Since commit ad67b74d2469d ("printk: hash addresses printed with
%p") pointers are hashed by default and the behaviour can be controller
by `hash_pointers' boot argument.
The policy on %p is to not introduce new ones.
Removing %pK makes it possible to remove its handling from the library.

Ideally I would the %p usage here but can't tell how important it is for
debugging.

Use %p instead %pK.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c  | 4 ++--
 drivers/platform/raspberrypi/vchiq-interface/vchiq_core.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
index e786417032522..c99f63b80addf 100644
--- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
+++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
@@ -891,7 +891,7 @@ void vchiq_dump_platform_instances(struct vchiq_state *state, struct seq_file *f
 		}
 		rcu_read_unlock();
 
-		seq_printf(f, "Instance %pK: pid %d,%s completions %d/%d\n",
+		seq_printf(f, "Instance %p: pid %d,%s completions %d/%d\n",
 			   instance, instance->pid,
 			   instance->connected ? " connected, " :
 			   "",
@@ -908,7 +908,7 @@ void vchiq_dump_platform_service_state(struct seq_file *f,
 	struct user_service *user_service =
 			(struct user_service *)service->base.userdata;
 
-	seq_printf(f, "  instance %pK", service->instance);
+	seq_printf(f, "  instance %p", service->instance);
 
 	if ((service->base.callback == service_callback) && user_service->is_vchi) {
 		seq_printf(f, ", %d/%d messages",
diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_core.c b/drivers/platform/raspberrypi/vchiq-interface/vchiq_core.c
index 48d6b1d743293..bb4e5015956d6 100644
--- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_core.c
+++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_core.c
@@ -3915,7 +3915,7 @@ void vchiq_dump_state(struct seq_file *f, struct vchiq_state *state)
 	seq_printf(f, "State %d: %s\n", state->id,
 		   conn_state_names[state->conn_state]);
 
-	seq_printf(f, "  tx_pos=0x%x(@%pK), rx_pos=0x%x(@%pK)\n",
+	seq_printf(f, "  tx_pos=0x%x(@%p), rx_pos=0x%x(@%p)\n",
 		   state->local->tx_pos,
 		   state->tx_data + (state->local_tx_pos & VCHIQ_SLOT_MASK),
 		   state->rx_pos,
-- 
2.55.0



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-09-18 10:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-18 10:44 [PATCH] platform/raspberrypi: Use %p for pointer formatting Sebastian Andrzej Siewior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox