* [PATCH] pinctrl: mediatek: mt7629: fix the 2.4 GHz Wi-Fi pin mode array
@ 2026-09-26 10:04 Chuanhong Guo
2026-10-01 8:34 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Chuanhong Guo @ 2026-09-26 10:04 UTC (permalink / raw)
To: Sean Wang, Linus Walleij, Ryder Lee
Cc: Matthias Brugger, AngeloGioacchino Del Regno, linux-mediatek,
linux-gpio, linux-kernel, linux-arm-kernel, Chuanhong Guo
The wf0_2g group contains nine pins but only eight mux values.
mtk_pinmux_set_mux() indexes the mode array once for each pin, reading
past its end when configuring pin 78 (WF0_2G_HB6). This can select an
unrelated mux value or fail with -EINVAL, preventing the Wi-Fi device
from probing.
Add the missing mode 1 entry for WF0_2G_HB6.
Fixes: b44677375fee ("pinctrl: mediatek: add pinctrl support for MT7629 SoC")
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
drivers/pinctrl/mediatek/pinctrl-mt7629.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt7629.c b/drivers/pinctrl/mediatek/pinctrl-mt7629.c
index 385d66b8e3fb..29a4c171e8b6 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mt7629.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mt7629.c
@@ -294,7 +294,7 @@ static int mt7629_pwm_1_funcs[] = { 2, };
/* WF 2G */
static int mt7629_wf0_2g_pins[] = { 70, 71, 72, 73, 74, 75, 76, 77, 78, };
-static int mt7629_wf0_2g_funcs[] = { 1, 1, 1, 1, 1, 1, 1, 1, };
+static int mt7629_wf0_2g_funcs[] = { 1, 1, 1, 1, 1, 1, 1, 1, 1, };
/* WF 5G */
static int mt7629_wf0_5g_pins[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, };
---
base-commit: f5f84daefcd92d7a630066635ecea1433ed5eac7
change-id: 20260926-b4-mt7629-pinctrl-1c6921e06627
Best regards,
--
Chuanhong Guo <gch981213@gmail.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: mediatek: mt7629: fix the 2.4 GHz Wi-Fi pin mode array
2026-09-26 10:04 [PATCH] pinctrl: mediatek: mt7629: fix the 2.4 GHz Wi-Fi pin mode array Chuanhong Guo
@ 2026-10-01 8:34 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2026-10-01 8:34 UTC (permalink / raw)
To: Chuanhong Guo
Cc: Sean Wang, Ryder Lee, Matthias Brugger,
AngeloGioacchino Del Regno, linux-mediatek, linux-gpio,
linux-kernel, linux-arm-kernel
On Sat, Sep 26, 2026 at 12:04 PM Chuanhong Guo <gch981213@gmail.com> wrote:
> The wf0_2g group contains nine pins but only eight mux values.
> mtk_pinmux_set_mux() indexes the mode array once for each pin, reading
> past its end when configuring pin 78 (WF0_2G_HB6). This can select an
> unrelated mux value or fail with -EINVAL, preventing the Wi-Fi device
> from probing.
>
> Add the missing mode 1 entry for WF0_2G_HB6.
>
> Fixes: b44677375fee ("pinctrl: mediatek: add pinctrl support for MT7629 SoC")
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
Patch applied as nonurgent fix.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-01 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-26 10:04 [PATCH] pinctrl: mediatek: mt7629: fix the 2.4 GHz Wi-Fi pin mode array Chuanhong Guo
2026-10-01 8:34 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox