From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: linux-arm-kernel@lists.infradead.org
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 06/11] ARM: BUG: Move the __BUG() out of CONFIG_DEBUG_BUGVERBOSE
Date: Sat, 10 Oct 2026 00:21:13 +0200 [thread overview]
Message-ID: <20261010-arm_warning-v1-6-ddf4be42ae0d@breakpoint.cc> (raw)
In-Reply-To: <20261010-arm_warning-v1-0-ddf4be42ae0d@breakpoint.cc>
Move the __BUG() macro out of the CONFIG_DEBUG_BUGVERBOSE block and
provide an empty _BUG_VERBOSE_LINE() macro for the
!CONFIG_DEBUG_BUGVERBOSE case.
This allows the removal of the other __BUG implementation (in the old
!CONFIG_DEBUG_BUGVERBOSE case). Remove BUG_INSTR which has no users now.
The side effect is that the entries in __bug_table are still added but
without FILE and LINE.
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
arch/arm/include/asm/bug.h | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h
index 172e6a84541cb..c47b693aed8ae 100644
--- a/arch/arm/include/asm/bug.h
+++ b/arch/arm/include/asm/bug.h
@@ -13,11 +13,9 @@
*/
#ifdef CONFIG_THUMB2_KERNEL
#define BUG_INSTR_VALUE 0xde02
-#define BUG_INSTR(__value) __inst_thumb16(__value)
#define BUG_ENCODING() .short ___asm_opcode_to_mem_thumb16(BUG_INSTR_VALUE)
#else
#define BUG_INSTR_VALUE 0xe7f001f2
-#define BUG_INSTR(__value) __inst_arm(__value)
#define BUG_ENCODING() .long ___asm_opcode_to_mem_arm(BUG_INSTR_VALUE)
#endif
@@ -26,7 +24,6 @@
#define _BUG(file, line, value) __BUG(file, line, value)
#ifdef CONFIG_DEBUG_BUGVERBOSE
-
#define _BUG_VERBOSE_LINE(__file, __line) \
.pushsection .rodata.str, "aMS", %progbits, 1; \
2: .asciz __file; \
@@ -35,6 +32,10 @@
.word 2b; \
.hword __line; \
+#else
+#define _BUG_VERBOSE_LINE(__file, __line)
+#endif
+
#ifdef CONFIG_GENERIC_BUG
#define __BUG_ENTRY_GENERIC(__file, __line, __value) \
.pushsection __bug_table,"aw"; \
@@ -65,15 +66,6 @@ do { \
unreachable(); \
} while (0)
-#else
-
-#define __BUG(__file, __line, __value) \
-do { \
- asm volatile(BUG_INSTR(__value) "\n"); \
- unreachable(); \
-} while (0)
-#endif /* CONFIG_DEBUG_BUGVERBOSE */
-
#define HAVE_ARCH_BUG
#include <asm-generic/bug.h>
--
2.55.0
next prev parent reply other threads:[~2026-10-09 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 22:21 [PATCH 00/11] ARM: Use invalid opcode also for warnings Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 01/11] ARM: BUG: Move the assembly out of __BUG() macro Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 02/11] ARM: BUG: Spent each entry in __BUG__LINE() its own line Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 03/11] ARM: BUG: Move the section right after the opcode Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 04/11] ARM: BUG: Move file/ line encoding into a custom macro Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 05/11] ARM: BUG: Move __bug_table creation to __BUG_ENTRY_GENERIC() macro Sebastian Andrzej Siewior
2026-10-09 22:21 ` Sebastian Andrzej Siewior [this message]
2026-10-09 22:21 ` [PATCH 07/11] ARM: BUG: Pass a flags argument to __BUG__LINE() Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 08/11] ARM: BUG: Move BUG() into the do-while loop Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 09/11] ARM: traps: Move the BUG handling from die() to do_undefinstr() Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 10/11] ARM: traps: Add handling for warnings to handle_bug_opcode() Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 11/11] ARM: BUG: Add WARN support via __WARN_FLAGS() Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010-arm_warning-v1-6-ddf4be42ae0d@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox