From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: linux-arm-kernel@lists.infradead.org
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 07/11] ARM: BUG: Pass a flags argument to __BUG__LINE()
Date: Sat, 10 Oct 2026 00:21:14 +0200 [thread overview]
Message-ID: <20261010-arm_warning-v1-7-ddf4be42ae0d@breakpoint.cc> (raw)
In-Reply-To: <20261010-arm_warning-v1-0-ddf4be42ae0d@breakpoint.cc>
Since the hard coding of the BUG-opcode, the value argument remained
unused. Repurpose that argument as flags from struct bug_entry. For now
this is set to 0.
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
arch/arm/include/asm/bug.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h
index c47b693aed8ae..b9e58be656360 100644
--- a/arch/arm/include/asm/bug.h
+++ b/arch/arm/include/asm/bug.h
@@ -20,8 +20,8 @@
#endif
-#define BUG() _BUG(__FILE__, __LINE__, BUG_INSTR_VALUE)
-#define _BUG(file, line, value) __BUG(file, line, value)
+#define BUG() _BUG(__FILE__, __LINE__)
+#define _BUG(file, line) __BUG(file, line)
#ifdef CONFIG_DEBUG_BUGVERBOSE
#define _BUG_VERBOSE_LINE(__file, __line) \
@@ -37,22 +37,22 @@
#endif
#ifdef CONFIG_GENERIC_BUG
-#define __BUG_ENTRY_GENERIC(__file, __line, __value) \
+#define __BUG_ENTRY_GENERIC(__file, __line, __flags) \
.pushsection __bug_table,"aw"; \
.align 2; \
.word 1b; \
_BUG_VERBOSE_LINE(__file, __line); \
- .hword 0; \
+ .hword __flags; \
.popsection;
#else
-#define __BUG_ENTRY_GENERIC(__file, __line, __value)
+#define __BUG_ENTRY_GENERIC(__file, __line, __flags)
#endif
-#define __BUG__LINE(__file, __line, __value) \
+#define __BUG__LINE(__file, __line, __flags) \
1: ; \
BUG_ENCODING(); \
- __BUG_ENTRY_GENERIC(__file, __line, __value);
+ __BUG_ENTRY_GENERIC(__file, __line, __flags);
/*
* The extra indirection is to ensure that the __FILE__ string comes through
@@ -60,9 +60,9 @@
* preferable to this unpleasantness. We use mergeable string sections to
* avoid multiple copies of the string appearing in the kernel image.
*/
-#define __BUG(__file, __line, __value) \
+#define __BUG(__file, __line) \
do { \
- asm volatile(__stringify(__BUG__LINE(__file, __line, __value))); \
+ asm volatile(__stringify(__BUG__LINE(__file, __line, 0))); \
unreachable(); \
} while (0)
--
2.55.0
next prev parent reply other threads:[~2026-10-09 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 22:21 [PATCH 00/11] ARM: Use invalid opcode also for warnings Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 01/11] ARM: BUG: Move the assembly out of __BUG() macro Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 02/11] ARM: BUG: Spent each entry in __BUG__LINE() its own line Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 03/11] ARM: BUG: Move the section right after the opcode Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 04/11] ARM: BUG: Move file/ line encoding into a custom macro Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 05/11] ARM: BUG: Move __bug_table creation to __BUG_ENTRY_GENERIC() macro Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 06/11] ARM: BUG: Move the __BUG() out of CONFIG_DEBUG_BUGVERBOSE Sebastian Andrzej Siewior
2026-10-09 22:21 ` Sebastian Andrzej Siewior [this message]
2026-10-09 22:21 ` [PATCH 08/11] ARM: BUG: Move BUG() into the do-while loop Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 09/11] ARM: traps: Move the BUG handling from die() to do_undefinstr() Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 10/11] ARM: traps: Add handling for warnings to handle_bug_opcode() Sebastian Andrzej Siewior
2026-10-09 22:21 ` [PATCH 11/11] ARM: BUG: Add WARN support via __WARN_FLAGS() Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010-arm_warning-v1-7-ddf4be42ae0d@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox