* [PATCH 0/7] sy7636a: power the panel only during updates
@ 2026-10-26 0:39 Pablo Mazzini
2026-10-26 0:39 ` [PATCH 1/7] ARM: dts: imx: keep the SY7636A VCOM on Pablo Mazzini
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Pablo Mazzini @ 2026-10-26 0:39 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood, Guenter Roeck, Lee Jones, Frank Li,
Sascha Hauer
Cc: Pablo Mazzini, Alistair Francis, Andreas Kemnade,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel, linux-hwmon, mfd, linux-kernel
The SY7636A hwmon driver keeps VCOM on from probe, so a display driver
can not power the panel only during updates.
Read the temperature in the regulator driver instead, as the TPS65185
and FP9931 drivers do, and remove the hwmon driver. Boards that relied
on VCOM staying on mark it always-on. The regulator also switches VCOM
with VCOM_EN, gains VCOM voltage control and binds to the I2C device
directly.
Tested on a PocketBook Verse (B288).
Pablo Mazzini (7):
ARM: dts: imx: keep the SY7636A VCOM on
regulator: sy7636a: fix the chip name
regulator: sy7636a: add VCOM voltage control
regulator: sy7636a: wait for power good, then switch VCOM_EN
regulator: sy7636a: report the temperature
regulator: sy7636a: bind to the I2C device directly
ARM: imx_v6_v7_defconfig: drop the SY7636A MFD and hwmon options
Documentation/hwmon/index.rst | 1 -
Documentation/hwmon/sy7636a-hwmon.rst | 26 --
arch/arm/boot/dts/nxp/imx/e70k02.dtsi | 1 +
.../boot/dts/nxp/imx/imx7d-remarkable2.dts | 1 +
arch/arm/configs/imx_v6_v7_defconfig | 2 -
drivers/hwmon/Kconfig | 10 -
drivers/hwmon/Makefile | 1 -
drivers/hwmon/sy7636a-hwmon.c | 102 --------
drivers/mfd/Kconfig | 10 -
drivers/mfd/simple-mfd-i2c.c | 11 -
drivers/regulator/Kconfig | 6 +-
drivers/regulator/sy7636a-regulator.c | 240 +++++++++++++++---
include/linux/mfd/sy7636a.h | 34 ---
13 files changed, 205 insertions(+), 240 deletions(-)
delete mode 100644 Documentation/hwmon/sy7636a-hwmon.rst
delete mode 100644 drivers/hwmon/sy7636a-hwmon.c
delete mode 100644 include/linux/mfd/sy7636a.h
base-commit: aac26bee2287c88af5be5a5ff96d783b19a28790
--
2.52.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/7] ARM: dts: imx: keep the SY7636A VCOM on
2026-10-26 0:39 [PATCH 0/7] sy7636a: power the panel only during updates Pablo Mazzini
@ 2026-10-26 0:39 ` Pablo Mazzini
2026-10-26 7:30 ` Andreas Kemnade
2026-10-26 0:39 ` [PATCH 7/7] ARM: imx_v6_v7_defconfig: drop the SY7636A MFD and hwmon options Pablo Mazzini
2026-10-26 9:37 ` [PATCH 0/7] sy7636a: power the panel only during updates Andreas Kemnade
2 siblings, 1 reply; 7+ messages in thread
From: Pablo Mazzini @ 2026-10-26 0:39 UTC (permalink / raw)
To: Frank Li, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Pablo Mazzini, Alistair Francis, Andreas Kemnade,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel, linux-kernel
The SY7636A hwmon driver turns VCOM on at probe. The reMarkable 2, Kobo
Libra H2O and Tolino Vision 5 have had the rails on so far. Mark VCOM
always-on before the driver stops doing it.
Signed-off-by: Pablo Mazzini <pmazzini@gmail.com>
---
arch/arm/boot/dts/nxp/imx/e70k02.dtsi | 1 +
| 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
index dc7ff108aa85..bd9c6c6fa117 100644
--- a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
@@ -154,6 +154,7 @@ sy7636: pmic@62 {
regulators {
reg_epdpmic: vcom {
regulator-name = "vcom";
+ regulator-always-on;
};
};
};
--git a/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts b/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts
index ff9d50942884..6cf5603c0752 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts
@@ -327,6 +327,7 @@ sy7636a: pmic@62 {
regulators {
reg_epdpmic: vcom {
regulator-name = "vcom";
+ regulator-always-on;
regulator-boot-on;
};
};
--
2.52.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 7/7] ARM: imx_v6_v7_defconfig: drop the SY7636A MFD and hwmon options
2026-10-26 0:39 [PATCH 0/7] sy7636a: power the panel only during updates Pablo Mazzini
2026-10-26 0:39 ` [PATCH 1/7] ARM: dts: imx: keep the SY7636A VCOM on Pablo Mazzini
@ 2026-10-26 0:39 ` Pablo Mazzini
2026-10-26 9:37 ` [PATCH 0/7] sy7636a: power the panel only during updates Andreas Kemnade
2 siblings, 0 replies; 7+ messages in thread
From: Pablo Mazzini @ 2026-10-26 0:39 UTC (permalink / raw)
To: Frank Li, Sascha Hauer
Cc: Pablo Mazzini, Alistair Francis, Andreas Kemnade,
Pengutronix Kernel Team, Fabio Estevam, imx, linux-arm-kernel,
linux-kernel
The SY7636A regulator driver now covers the whole chip.
Signed-off-by: Pablo Mazzini <pmazzini@gmail.com>
---
arch/arm/configs/imx_v6_v7_defconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 6ac42c06c1e9..bd1f692dd7b2 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -223,7 +223,6 @@ CONFIG_SENSORS_IIO_HWMON=y
CONFIG_SENSORS_JC42=m
CONFIG_SENSORS_LM75=m
CONFIG_SENSORS_PWM_FAN=y
-CONFIG_SENSORS_SY7636A=y
CONFIG_THERMAL_STATISTICS=y
CONFIG_CPU_THERMAL=y
CONFIG_IMX_THERMAL=y
@@ -238,7 +237,6 @@ CONFIG_MFD_DA9062=y
CONFIG_MFD_DA9063=y
CONFIG_MFD_MC13XXX_SPI=y
CONFIG_MFD_MC13XXX_I2C=y
-CONFIG_MFD_SY7636A=y
CONFIG_MFD_RN5T618=y
CONFIG_MFD_STMPE=y
CONFIG_MFD_ROHM_BD71828=y
--
2.52.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/7] ARM: dts: imx: keep the SY7636A VCOM on
2026-10-26 0:39 ` [PATCH 1/7] ARM: dts: imx: keep the SY7636A VCOM on Pablo Mazzini
@ 2026-10-26 7:30 ` Andreas Kemnade
2026-10-26 8:21 ` Pablo Mazzini
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Kemnade @ 2026-10-26 7:30 UTC (permalink / raw)
To: Pablo Mazzini
Cc: Frank Li, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alistair Francis, Pengutronix Kernel Team,
Fabio Estevam, devicetree, imx, linux-arm-kernel, linux-kernel
On Mon, 26 Oct 2026 00:39:12 +0000
Pablo Mazzini <pmazzini@gmail.com> wrote:
> The SY7636A hwmon driver turns VCOM on at probe. The reMarkable 2, Kobo
> Libra H2O and Tolino Vision 5 have had the rails on so far. Mark VCOM
> always-on before the driver stops doing it.
>
> Signed-off-by: Pablo Mazzini <pmazzini@gmail.com>
> ---
> arch/arm/boot/dts/nxp/imx/e70k02.dtsi | 1 +
> arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
> index dc7ff108aa85..bd9c6c6fa117 100644
> --- a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
> @@ -154,6 +154,7 @@ sy7636: pmic@62 {
> regulators {
> reg_epdpmic: vcom {
> regulator-name = "vcom";
> + regulator-always-on;
> };
> };
> };
No, please not. That regulator is in practice used with a not yet upstreamed
driver for the EPDC on that platform used to deal with the current kernels
fp9931 / tps65185 drivers. So it is very welcome to have it not always turned
on.
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts b/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts
> index ff9d50942884..6cf5603c0752 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts
> @@ -327,6 +327,7 @@ sy7636a: pmic@62 {
> regulators {
> reg_epdpmic: vcom {
> regulator-name = "vcom";
> + regulator-always-on;
> regulator-boot-on;
> };
> };
Here the situation is a bit different. If I remember correctly, there
is some special EPD logic in userspace on top of some ordinary kernel
display driver. But thesse things are missing is devicetree?! But
that might need to learn to deal with regulator enabling/disabling.
Regulator always on is probably not desired here, either.
Regards,
Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/7] ARM: dts: imx: keep the SY7636A VCOM on
2026-10-26 7:30 ` Andreas Kemnade
@ 2026-10-26 8:21 ` Pablo Mazzini
0 siblings, 0 replies; 7+ messages in thread
From: Pablo Mazzini @ 2026-10-26 8:21 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Frank Li, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alistair Francis, Pengutronix Kernel Team,
Fabio Estevam, devicetree, imx, linux-arm-kernel, linux-kernel
Thanks, I will drop this patch in v2, so VCOM stays off until a consumer
enables it.
On Mon, Oct 26, 2026 at 7:31 AM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> On Mon, 26 Oct 2026 00:39:12 +0000
> Pablo Mazzini <pmazzini@gmail.com> wrote:
>
> > The SY7636A hwmon driver turns VCOM on at probe. The reMarkable 2, Kobo
> > Libra H2O and Tolino Vision 5 have had the rails on so far. Mark VCOM
> > always-on before the driver stops doing it.
> >
> > Signed-off-by: Pablo Mazzini <pmazzini@gmail.com>
> > ---
> > arch/arm/boot/dts/nxp/imx/e70k02.dtsi | 1 +
> > arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
> > index dc7ff108aa85..bd9c6c6fa117 100644
> > --- a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
> > @@ -154,6 +154,7 @@ sy7636: pmic@62 {
> > regulators {
> > reg_epdpmic: vcom {
> > regulator-name = "vcom";
> > + regulator-always-on;
> > };
> > };
> > };
> No, please not. That regulator is in practice used with a not yet upstreamed
> driver for the EPDC on that platform used to deal with the current kernels
> fp9931 / tps65185 drivers. So it is very welcome to have it not always turned
> on.
>
>
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts b/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts
> > index ff9d50942884..6cf5603c0752 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts
> > +++ b/arch/arm/boot/dts/nxp/imx/imx7d-remarkable2.dts
> > @@ -327,6 +327,7 @@ sy7636a: pmic@62 {
> > regulators {
> > reg_epdpmic: vcom {
> > regulator-name = "vcom";
> > + regulator-always-on;
> > regulator-boot-on;
> > };
> > };
>
>
> Here the situation is a bit different. If I remember correctly, there
> is some special EPD logic in userspace on top of some ordinary kernel
> display driver. But thesse things are missing is devicetree?! But
> that might need to learn to deal with regulator enabling/disabling.
>
> Regulator always on is probably not desired here, either.
>
> Regards,
> Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/7] sy7636a: power the panel only during updates
2026-10-26 0:39 [PATCH 0/7] sy7636a: power the panel only during updates Pablo Mazzini
2026-10-26 0:39 ` [PATCH 1/7] ARM: dts: imx: keep the SY7636A VCOM on Pablo Mazzini
2026-10-26 0:39 ` [PATCH 7/7] ARM: imx_v6_v7_defconfig: drop the SY7636A MFD and hwmon options Pablo Mazzini
@ 2026-10-26 9:37 ` Andreas Kemnade
2026-10-26 11:28 ` Pablo Mazzini
2 siblings, 1 reply; 7+ messages in thread
From: Andreas Kemnade @ 2026-10-26 9:37 UTC (permalink / raw)
To: Pablo Mazzini
Cc: Mark Brown, Liam Girdwood, Guenter Roeck, Lee Jones, Frank Li,
Sascha Hauer, Alistair Francis, Pengutronix Kernel Team,
Fabio Estevam, devicetree, imx, linux-arm-kernel, linux-hwmon,
mfd, linux-kernel
On Mon, 26 Oct 2026 00:39:11 +0000
Pablo Mazzini <pmazzini@gmail.com> wrote:
> The SY7636A hwmon driver keeps VCOM on from probe, so a display driver
> can not power the panel only during updates.
>
Yes, that is the common use case, power things on, tune update process
to the temperature, update, power off. So it makes completely sense.
> Read the temperature in the regulator driver instead, as the TPS65185
> and FP9931 drivers do, and remove the hwmon driver. Boards that relied
> on VCOM staying on mark it always-on. The regulator also switches VCOM
> with VCOM_EN, gains VCOM voltage control and binds to the I2C device
> directly.
>
> Tested on a PocketBook Verse (B288).
>
Which kernel do you use? Just curious, maybe some further upstreaming
actions might be coordinated or cross-reviewed.
There was discussion about in-kernel hwmon readout interface like it
exists for iio.
Regards,
Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/7] sy7636a: power the panel only during updates
2026-10-26 9:37 ` [PATCH 0/7] sy7636a: power the panel only during updates Andreas Kemnade
@ 2026-10-26 11:28 ` Pablo Mazzini
0 siblings, 0 replies; 7+ messages in thread
From: Pablo Mazzini @ 2026-10-26 11:28 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Mark Brown, Liam Girdwood, Guenter Roeck, Lee Jones, Frank Li,
Sascha Hauer, Alistair Francis, Pengutronix Kernel Team,
Fabio Estevam, devicetree, imx, linux-arm-kernel, linux-hwmon,
mfd, linux-kernel
Mainline, on top of linux-next. I started looking at the hwmon IIO
bridge. Coordinating and cross-reviewing further work sounds good.
On Mon, Oct 26, 2026 at 9:37 AM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> On Mon, 26 Oct 2026 00:39:11 +0000
> Pablo Mazzini <pmazzini@gmail.com> wrote:
>
> > The SY7636A hwmon driver keeps VCOM on from probe, so a display driver
> > can not power the panel only during updates.
> >
> Yes, that is the common use case, power things on, tune update process
> to the temperature, update, power off. So it makes completely sense.
>
> > Read the temperature in the regulator driver instead, as the TPS65185
> > and FP9931 drivers do, and remove the hwmon driver. Boards that relied
> > on VCOM staying on mark it always-on. The regulator also switches VCOM
> > with VCOM_EN, gains VCOM voltage control and binds to the I2C device
> > directly.
> >
> > Tested on a PocketBook Verse (B288).
> >
> Which kernel do you use? Just curious, maybe some further upstreaming
> actions might be coordinated or cross-reviewed.
> There was discussion about in-kernel hwmon readout interface like it
> exists for iio.
>
> Regards,
> Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-10-26 11:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-26 0:39 [PATCH 0/7] sy7636a: power the panel only during updates Pablo Mazzini
2026-10-26 0:39 ` [PATCH 1/7] ARM: dts: imx: keep the SY7636A VCOM on Pablo Mazzini
2026-10-26 7:30 ` Andreas Kemnade
2026-10-26 8:21 ` Pablo Mazzini
2026-10-26 0:39 ` [PATCH 7/7] ARM: imx_v6_v7_defconfig: drop the SY7636A MFD and hwmon options Pablo Mazzini
2026-10-26 9:37 ` [PATCH 0/7] sy7636a: power the panel only during updates Andreas Kemnade
2026-10-26 11:28 ` Pablo Mazzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox