[PATCH 0/3] dmaengine: remove redundant pm_runtime_dont_use_autosuspend() calls

[PATCH 0/3] dmaengine: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Joshua Crofts (3):
  dmaengine: at_xdmac: remove redundant
    pm_runtime_dont_use_autosuspend() calls
  dmaengine: qcom: remove redundant pm_runtime_dont_use_autosuspend()
    calls
  dmaengine: ti: remove redundant pm_runtime_dont_use_autosuspend()
    calls

 drivers/dma/at_xdmac.c     | 2 --
 drivers/dma/qcom/bam_dma.c | 1 -
 drivers/dma/ti/cppi41.c    | 5 +----
 3 files changed, 1 insertion(+), 7 deletions(-)


base-commit: d89e1d186ec9271bf78e62771779e9fc03bf0fc3
-- 
2.47.3

[PATCH 1/3] dmaengine: at_xdmac: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
 drivers/dma/at_xdmac.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index d40a8b40dddc..00a8261248f8 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -2427,7 +2427,6 @@ static int at_xdmac_probe(struct platform_device *pdev)
 	pm_runtime_put_noidle(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 	pm_runtime_set_suspended(&pdev->dev);
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 err_clk_disable:
 	clk_disable_unprepare(atxdmac->clk);
 err_free_irq:
@@ -2445,7 +2444,6 @@ static void at_xdmac_remove(struct platform_device *pdev)
 	dma_async_device_unregister(&atxdmac->dma);
 	pm_runtime_disable(atxdmac->dev);
 	pm_runtime_set_suspended(&pdev->dev);
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	clk_disable_unprepare(atxdmac->clk);
 
 	free_irq(atxdmac->irq, atxdmac);
-- 
2.47.3

[PATCH 2/3] dmaengine: qcom: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
 drivers/dma/qcom/bam_dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
index f67a93a37d48..efc155c61b07 100644
--- a/drivers/dma/qcom/bam_dma.c
+++ b/drivers/dma/qcom/bam_dma.c
@@ -1403,7 +1403,6 @@ static void bam_dma_remove(struct platform_device *pdev)
 	struct bam_device *bdev = platform_get_drvdata(pdev);
 	u32 i;
 
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_force_suspend(&pdev->dev);
 
 	of_dma_controller_free(pdev->dev.of_node);
-- 
2.47.3

[PATCH 3/3] dmaengine: ti: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls. Additionally, remove an unneeded
label as a consequence.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
 drivers/dma/ti/cppi41.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c
index 88756dccd62c..e1132e330fad 100644
--- a/drivers/dma/ti/cppi41.c
+++ b/drivers/dma/ti/cppi41.c
@@ -1108,7 +1108,7 @@ static int cppi41_dma_probe(struct platform_device *pdev)
 
 	ret = init_cppi41(dev, cdd);
 	if (ret)
-		goto err_init_cppi;
+		goto err_get_n_chans;
 
 	ret = cppi41_add_chans(dev, cdd);
 	if (ret)
@@ -1142,8 +1142,6 @@ static int cppi41_dma_probe(struct platform_device *pdev)
 	dma_async_device_unregister(&cdd->ddev);
 err_chans:
 	deinit_cppi41(dev, cdd);
-err_init_cppi:
-	pm_runtime_dont_use_autosuspend(dev);
 err_get_n_chans:
 err_get_sync:
 	pm_runtime_put_sync(dev);
@@ -1165,7 +1163,6 @@ static void cppi41_dma_remove(struct platform_device *pdev)
 
 	devm_free_irq(&pdev->dev, cdd->irq, cdd);
 	deinit_cppi41(&pdev->dev, cdd);
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_put_sync(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 }
-- 
2.47.3

Re: [PATCH 0/3] dmaengine: remove redundant pm_runtime_dont_use_autosuspend() calls

[Frank Li]

On Fri, Oct 30, 2026 at 02:58:58PM +0000, Joshua Crofts wrote:
> [You don't often get email from crofts@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
>
> Remove the redundant function calls.
>
> Joshua Crofts (3):
>   dmaengine: at_xdmac: remove redundant
>     pm_runtime_dont_use_autosuspend() calls
>   dmaengine: qcom: remove redundant pm_runtime_dont_use_autosuspend()
>     calls
>   dmaengine: ti: remove redundant pm_runtime_dont_use_autosuspend()
>     calls

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>
>  drivers/dma/at_xdmac.c     | 2 --
>  drivers/dma/qcom/bam_dma.c | 1 -
>  drivers/dma/ti/cppi41.c    | 5 +----
>  3 files changed, 1 insertion(+), 7 deletions(-)
>
>
> base-commit: d89e1d186ec9271bf78e62771779e9fc03bf0fc3
> --
> 2.47.3
>