Re: [PATCH] media: rkisp1: Depend on PM

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Mon, Nov 02, 2026 at 05:49:46PM +0000, Igor Velkov via B4 Relay wrote:
> From: Igor Velkov <iav@iav.lv>
> 
> rkisp1_runtime_resume() enables the clocks and lets the interrupt
> handlers run. Without CONFIG_PM it is never called, so rkisp1_probe()
> reads RKISP1_CIF_VI_ID with the clocks disabled and every interrupt
> handler returns IRQ_NONE.
> 
> ARCH_ROCKCHIP and arm64 ARCH_MXC select PM,

Why do we need this patch then ?

> and no arm32 i.MX has this
> ISP, so only COMPILE_TEST builds lose the driver. rkcif already depends
> on PM.
> 
> Signed-off-by: Igor Velkov <iav@iav.lv>
> ---
> Split out of the rkvdec CONFIG_PM discussion, as Nicolas asked [1].
> Without PM, olddefconfig on arm64 COMPILE_TEST now drops the driver;
> with PM it builds as before (W=1).
> 
> [1] https://lore.kernel.org/r/8aafdbbf04a0d939c6b4d7d5577d97bb58d1c439.camel@collabora.com
> ---
>  drivers/media/platform/rockchip/rkisp1/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/rockchip/rkisp1/Kconfig b/drivers/media/platform/rockchip/rkisp1/Kconfig
> index f53eb1f3f3e7..c825fbacee96 100644
> --- a/drivers/media/platform/rockchip/rkisp1/Kconfig
> +++ b/drivers/media/platform/rockchip/rkisp1/Kconfig
> @@ -4,6 +4,7 @@ config VIDEO_ROCKCHIP_ISP1
>  	depends on V4L_PLATFORM_DRIVERS
>  	depends on VIDEO_DEV && OF
>  	depends on ARCH_ROCKCHIP || ARCH_MXC || COMPILE_TEST
> +	depends on PM
>  	select MEDIA_CONTROLLER
>  	select VIDEO_V4L2_SUBDEV_API
>  	select VIDEOBUF2_DMA_CONTIG
> 
> ---
> base-commit: 27285b099fbc5cb2ae3aef20f3bbd7b3c88b3005
> change-id: 20261102-rkisp1-depends-on-pm-219d94239b56

-- 
Regards,

Laurent Pinchart