From: Sudeep Holla <sudeep.holla@kernel.org>
To: linux-arm-kernel@lists.infradead.org
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
kernel test robot <lkp@intel.com>
Subject: [PATCH] firmware: arm: smccc: Mark smccc_soc_id_{version,revision} as static
Date: Thu, 12 Nov 2026 18:05:43 +0000 [thread overview]
Message-ID: <20261112180543.45606-1-sudeep.holla@kernel.org> (raw)
Sparse warns:
| drivers/firmware/arm/smccc/smccc.c:21:21: sparse: sparse: symbol
| 'smccc_soc_id_version' was not declared. Should it be static?
| drivers/firmware/arm/smccc/smccc.c:22:21: sparse: sparse: symbol
| 'smccc_soc_id_revision' was not declared. Should it be static?
Fix the same by declaring those variables as static.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202611092008.peLqOBq7-lkp@intel.com/
Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
---
drivers/firmware/arm/smccc/smccc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/arm/smccc/smccc.c b/drivers/firmware/arm/smccc/smccc.c
index 5dc768ac4143..5901ca28887e 100644
--- a/drivers/firmware/arm/smccc/smccc.c
+++ b/drivers/firmware/arm/smccc/smccc.c
@@ -18,8 +18,8 @@ static u32 smccc_version = ARM_SMCCC_VERSION_1_0;
static enum arm_smccc_conduit smccc_conduit = SMCCC_CONDUIT_NONE;
bool __ro_after_init smccc_trng_available = false;
-s32 __ro_after_init smccc_soc_id_version = SMCCC_RET_NOT_SUPPORTED;
-s32 __ro_after_init smccc_soc_id_revision = SMCCC_RET_NOT_SUPPORTED;
+static s32 __ro_after_init smccc_soc_id_version = SMCCC_RET_NOT_SUPPORTED;
+static s32 __ro_after_init smccc_soc_id_revision = SMCCC_RET_NOT_SUPPORTED;
void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit)
{
base-commit: 49c49ca0c4d02848a9576f72c4741c38c5ba09de
--
2.43.0
reply other threads:[~2026-11-12 18:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112180543.45606-1-sudeep.holla@kernel.org \
--to=sudeep.holla@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox