Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] firmware: arm: smccc: Mark smccc_soc_id_{version,revision} as static
@ 2026-11-12 18:05 Sudeep Holla
  0 siblings, 0 replies; only message in thread
From: Sudeep Holla @ 2026-11-12 18:05 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Sudeep Holla, Mark Rutland, Lorenzo Pieralisi, kernel test robot

Sparse warns:

 | drivers/firmware/arm/smccc/smccc.c:21:21: sparse: sparse: symbol
 |		'smccc_soc_id_version' was not declared. Should it be static?
 | drivers/firmware/arm/smccc/smccc.c:22:21: sparse: sparse: symbol
 |		'smccc_soc_id_revision' was not declared. Should it be static?

Fix the same by declaring those variables as static.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202611092008.peLqOBq7-lkp@intel.com/
Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
---
 drivers/firmware/arm/smccc/smccc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/arm/smccc/smccc.c b/drivers/firmware/arm/smccc/smccc.c
index 5dc768ac4143..5901ca28887e 100644
--- a/drivers/firmware/arm/smccc/smccc.c
+++ b/drivers/firmware/arm/smccc/smccc.c
@@ -18,8 +18,8 @@ static u32 smccc_version = ARM_SMCCC_VERSION_1_0;
 static enum arm_smccc_conduit smccc_conduit = SMCCC_CONDUIT_NONE;
 
 bool __ro_after_init smccc_trng_available = false;
-s32 __ro_after_init smccc_soc_id_version = SMCCC_RET_NOT_SUPPORTED;
-s32 __ro_after_init smccc_soc_id_revision = SMCCC_RET_NOT_SUPPORTED;
+static s32 __ro_after_init smccc_soc_id_version = SMCCC_RET_NOT_SUPPORTED;
+static s32 __ro_after_init smccc_soc_id_revision = SMCCC_RET_NOT_SUPPORTED;
 
 void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit)
 {

base-commit: 49c49ca0c4d02848a9576f72c4741c38c5ba09de
-- 
2.43.0



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-12 18:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-12 18:05 [PATCH] firmware: arm: smccc: Mark smccc_soc_id_{version,revision} as static Sudeep Holla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox