* [PATCH] platform/raspberrypi: vchiq: Fix kernel-doc Return section
[not found] <20261110-vchiq-dev-kdoc-return-v1-1-dac3e840bcac.ref@yahoo.pl>
@ 2026-11-10 21:38 ` Tomasz Unger
2026-11-14 3:32 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Unger @ 2026-11-10 21:38 UTC (permalink / raw)
To: Florian Fainelli
Cc: Broadcom internal kernel review list, Greg Kroah-Hartman,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, Tomasz Unger
scripts/kernel-doc -Wall reports that vchiq_register_chrdev() has no
description of its return value:
Warning: drivers/platform/raspberrypi/vchiq-interface/vchiq_dev.c:1341
No description found for return value of 'vchiq_register_chrdev'
The comment does describe it, but in a free-form "Returns 0 on success
..." sentence that kernel-doc does not recognize. Convert it to a
"Return:" section.
No functional change.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/platform/raspberrypi/vchiq-interface/vchiq_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_dev.c b/drivers/platform/raspberrypi/vchiq-interface/vchiq_dev.c
index f1c9c0d4b96a..7dfeebbf34d3 100644
--- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_dev.c
+++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_dev.c
@@ -1336,7 +1336,7 @@ static struct miscdevice vchiq_miscdev = {
* device files in userspace.
* @parent: The parent of the char device.
*
- * Returns 0 on success else returns the error code.
+ * Return: 0 on success, or a negative error code on failure.
*/
int vchiq_register_chrdev(struct device *parent)
{
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261110-vchiq-dev-kdoc-return-5ba9491d7f0c
Best regards,
--
Tomasz Unger <tomasz.unger@yahoo.pl>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/raspberrypi: vchiq: Fix kernel-doc Return section
2026-11-10 21:38 ` [PATCH] platform/raspberrypi: vchiq: Fix kernel-doc Return section Tomasz Unger
@ 2026-11-14 3:32 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2026-11-14 3:32 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Tomasz Unger, Florian Fainelli
Cc: Florian Fainelli, Greg Kroah-Hartman, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
On Tue, 10 Nov 2026 22:38:25 +0100, Tomasz Unger <tomasz.unger@yahoo.pl> wrote:
> scripts/kernel-doc -Wall reports that vchiq_register_chrdev() has no
> description of its return value:
>
> Warning: drivers/platform/raspberrypi/vchiq-interface/vchiq_dev.c:1341
> No description found for return value of 'vchiq_register_chrdev'
>
> The comment does describe it, but in a free-form "Returns 0 on success
> ..." sentence that kernel-doc does not recognize. Convert it to a
> "Return:" section.
>
> No functional change.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-14 3:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20261110-vchiq-dev-kdoc-return-v1-1-dac3e840bcac.ref@yahoo.pl>
2026-11-10 21:38 ` [PATCH] platform/raspberrypi: vchiq: Fix kernel-doc Return section Tomasz Unger
2026-11-14 3:32 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox