* [PATCH] arm64: dts: ti: k3-j722s-evm: Fix USB2.0_MUX_SEL hog polarity for Type-C
@ 2026-11-20 12:23 MD Danish Anwar
2026-11-20 12:26 ` Siddharth Vadapalli
0 siblings, 1 reply; 2+ messages in thread
From: MD Danish Anwar @ 2026-11-20 12:23 UTC (permalink / raw)
To: Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Siddharth Vadapalli, linux-arm-kernel, devicetree, danishanwar
According to the "USB Type-C Mux" section of the J722S EVM Schematic
within the Evaluation Module Design Files package [0], the Type-C
connector is connected to USB0 when USB2.0_MUX_SEL, Pin P05 of GPIO
Expander 1 (I2C0/0x23), is low.
Commit 65ba2a6e77e9 ("arm64: dts: ti: k3-j722s-evm: Fix USB gpio-hog
level for Type-C") changed the p05-hog from output-high to output-low
while keeping GPIO_ACTIVE_LOW. As the polarity flag is applied before the
level, output-low with GPIO_ACTIVE_LOW drives the pin physically high.
USB0 then does not work on the Type-C port: with the gadget bound, the UDC
stays "not attached" and the host sees no device.
Use GPIO_ACTIVE_HIGH with output-low, so that P05 is driven physically
low as the schematic requires to select Type-C, and the devicetree reads
the same as the schematic.
[0]: https://www.ti.com/lit/zip/sprr495
Fixes: 65ba2a6e77e9 ("arm64: dts: ti: k3-j722s-evm: Fix USB gpio-hog level for Type-C")
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
index c6486cf5a05c..80a915925c1c 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
@@ -586,7 +586,7 @@ exp1: gpio@23 {
p05-hog {
/* P05 - USB2.0_MUX_SEL */
gpio-hog;
- gpios = <5 GPIO_ACTIVE_LOW>;
+ gpios = <5 GPIO_ACTIVE_HIGH>;
output-low;
};
base-commit: adcad7f4e6332cff3d6d7165f41584899f598534
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-j722s-evm: Fix USB2.0_MUX_SEL hog polarity for Type-C
2026-11-20 12:23 [PATCH] arm64: dts: ti: k3-j722s-evm: Fix USB2.0_MUX_SEL hog polarity for Type-C MD Danish Anwar
@ 2026-11-20 12:26 ` Siddharth Vadapalli
0 siblings, 0 replies; 2+ messages in thread
From: Siddharth Vadapalli @ 2026-11-20 12:26 UTC (permalink / raw)
To: MD Danish Anwar
Cc: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
s-vadapalli
On 11/20/26 5:53 PM, MD Danish Anwar wrote:
> According to the "USB Type-C Mux" section of the J722S EVM Schematic
> within the Evaluation Module Design Files package [0], the Type-C
> connector is connected to USB0 when USB2.0_MUX_SEL, Pin P05 of GPIO
> Expander 1 (I2C0/0x23), is low.
>
> Commit 65ba2a6e77e9 ("arm64: dts: ti: k3-j722s-evm: Fix USB gpio-hog
> level for Type-C") changed the p05-hog from output-high to output-low
> while keeping GPIO_ACTIVE_LOW. As the polarity flag is applied before the
> level, output-low with GPIO_ACTIVE_LOW drives the pin physically high.
> USB0 then does not work on the Type-C port: with the gadget bound, the UDC
> stays "not attached" and the host sees no device.
>
> Use GPIO_ACTIVE_HIGH with output-low, so that P05 is driven physically
> low as the schematic requires to select Type-C, and the devicetree reads
> the same as the schematic.
>
> [0]: https://www.ti.com/lit/zip/sprr495
>
> Fixes: 65ba2a6e77e9 ("arm64: dts: ti: k3-j722s-evm: Fix USB gpio-hog level for Type-C")
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Thank you for fixing this.
Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Regards,
Siddharth.
> ---
> arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index c6486cf5a05c..80a915925c1c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -586,7 +586,7 @@ exp1: gpio@23 {
> p05-hog {
> /* P05 - USB2.0_MUX_SEL */
> gpio-hog;
> - gpios = <5 GPIO_ACTIVE_LOW>;
> + gpios = <5 GPIO_ACTIVE_HIGH>;
> output-low;
> };
>
>
> base-commit: adcad7f4e6332cff3d6d7165f41584899f598534
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-20 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 12:23 [PATCH] arm64: dts: ti: k3-j722s-evm: Fix USB2.0_MUX_SEL hog polarity for Type-C MD Danish Anwar
2026-11-20 12:26 ` Siddharth Vadapalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox