Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 0/2] ACPI: platform: ACPI 6.5 fixed clock support
@ 2026-11-20 12:57 Paul Cercueil
  2026-11-20 12:57 ` [PATCH v4 1/2] clkdev: Improve clock discovery with clk_find() Paul Cercueil
  2026-11-20 12:57 ` [PATCH v4 2/2] ACPI: platform: Add basic support for ACPI 6.5 fixed clock resources Paul Cercueil
  0 siblings, 2 replies; 3+ messages in thread
From: Paul Cercueil @ 2026-11-20 12:57 UTC (permalink / raw)
  To: Rafael J . Wysocki, Len Brown, Russell King
  Cc: linux-acpi, linux-kernel, linux-arm-kernel, Thomas Petazzoni,
	Paul Cercueil

Hi Rafael, Russell,

Here's the v4 of my patchset that adds partial support for ACPI 6.5
clock resources.

Sashiko complained about the clock names being too long still, as
ACPI device names can be up to 17 characters and the limit of clock
names is 16 characters; so I now name them "acpi-clkX".

Note that I expect warnings from Sashiko that I got on my v3 and didn't
correct, because they are bogus.

On the clkdev patch:
"When clk_find(dev_id, NULL) is called, does incrementing match here
give a (dev_id, con_id) entry a higher score than an exact
(dev_id, NULL) entry?"

My answer is that you call clk_find(dev_id, NULL) when you know you only
have one clock provided, so you don't need to care about matching
priorities.

On the ACPI patch:
"Should the con_id argument to devm_clk_hw_register_clkdev() be NULL
instead of name? [...] Setting con_id to "<dev_name>-<idx>" instead of
NULL prevents wildcard connection matching in clk_find(), so any
consumer driver calling clk_get(dev, con_id) with a non-NULL con_id
fails with -ENOENT."

That's completely ignoring the first patch, which addresses this issue.

So I consider that those two issues can be ignored.

Changelog since v3:

- [2/2]:
  - Change clock names to "acpi-clkX", because ACPI devices names can be
    up to 17 characters long, and our clock name must be 16 characters
    max.

Cheers,
-Paul

Paul Cercueil (2):
  clkdev: Improve clock discovery with clk_find()
  ACPI: platform: Add basic support for ACPI 6.5 fixed clock resources

 drivers/acpi/acpi_platform.c | 64 ++++++++++++++++++++++++++++++++++++
 drivers/clk/clkdev.c         |  4 ++-
 2 files changed, 67 insertions(+), 1 deletion(-)

-- 
2.47.3



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20 12:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 12:57 [PATCH v4 0/2] ACPI: platform: ACPI 6.5 fixed clock support Paul Cercueil
2026-11-20 12:57 ` [PATCH v4 1/2] clkdev: Improve clock discovery with clk_find() Paul Cercueil
2026-11-20 12:57 ` [PATCH v4 2/2] ACPI: platform: Add basic support for ACPI 6.5 fixed clock resources Paul Cercueil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox