* Re: [PATCH v2 5/5] phy: apple: atc: Split generation-specific code
[not found] <20261122-t8122-phy-v2-5-8d5c8fdf31ba@chaosmail.tech>
@ 2026-11-22 20:23 ` kernel test robot
2026-11-22 21:36 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-11-22 20:23 UTC (permalink / raw)
To: Sasha Finkelstein, Sven Peter, Janne Grunau, Vinod Koul,
Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: oe-kbuild-all, asahi, linux-arm-kernel, linux-phy, devicetree,
linux-kernel, Sasha Finkelstein
Hi Sasha,
kernel test robot noticed the following build errors:
[auto build test ERROR on 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4]
url: https://github.com/intel-lab-lkp/linux/commits/Sasha-Finkelstein/dt-bindings-phy-atcphy-Add-M3-series/20261122-132757
base: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
patch link: https://lore.kernel.org/r/20261122-t8122-phy-v2-5-8d5c8fdf31ba%40chaosmail.tech
patch subject: [PATCH v2 5/5] phy: apple: atc: Split generation-specific code
config: x86_64-buildonly-randconfig-1005-20261122 (https://download.01.org/0day-ci/archive/20261123/202611230426.XGazeYTu-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261123/202611230426.XGazeYTu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611230426.XGazeYTu-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/phy/apple/atc-t8103.c: In function 'atcphy_configure_pipehandler_usb3_host_t8103':
>> drivers/phy/apple/atc-t8103.c:33:21: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
33 | FIELD_PREP(ACIOPHY_TOP_BIST_PHY_CFG1_LN0_PWR_DOWN, 3));
| ^~~~~~~~~~
--
drivers/phy/apple/atc-t8122.c: In function 'atcphy_configure_pipehandler_usb3_host_t8122':
>> drivers/phy/apple/atc-t8122.c:78:16: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
78 | FIELD_PREP(ACIOPHY_BIST_MAC_USBPHY_CFG_OV1_LN0_PWR_DOWN_OV, 2),
| ^~~~~~~~~~
vim +/FIELD_PREP +33 drivers/phy/apple/atc-t8103.c
11
12 static void atcphy_configure_pipehandler_usb3_host_t8103(struct apple_atcphy *atcphy)
13 {
14 int ret;
15 u32 reg;
16
17 core_set32(atcphy, ACIOPHY_TOP_BIST_PHY_CFG0,
18 ACIOPHY_TOP_BIST_PHY_CFG0_LN0_RESET_N);
19 core_set32(atcphy, ACIOPHY_TOP_BIST_OV_CFG, ACIOPHY_TOP_BIST_OV_CFG_LN0_RESET_N_OV);
20 ret = readl_poll_timeout(atcphy->regs.core + ACIOPHY_TOP_PHY_STAT, reg,
21 !(reg & ACIOPHY_TOP_PHY_STAT_LN0_UNK23), 10, 10000);
22 if (ret)
23 dev_warn(atcphy->dev,
24 "Timed out waiting for ACIOPHY_TOP_PHY_STAT_LN0_UNK23\n");
25
26 core_set32(atcphy, ACIOPHY_TOP_BIST_READ_CTRL,
27 ACIOPHY_TOP_BIST_READ_CTRL_LN0_PHY_STATUS_RE);
28 core_clear32(atcphy, ACIOPHY_TOP_BIST_READ_CTRL,
29 ACIOPHY_TOP_BIST_READ_CTRL_LN0_PHY_STATUS_RE);
30
31 core_mask32(atcphy, ACIOPHY_TOP_BIST_PHY_CFG1,
32 ACIOPHY_TOP_BIST_PHY_CFG1_LN0_PWR_DOWN,
> 33 FIELD_PREP(ACIOPHY_TOP_BIST_PHY_CFG1_LN0_PWR_DOWN, 3));
34
35 core_set32(atcphy, ACIOPHY_TOP_BIST_OV_CFG,
36 ACIOPHY_TOP_BIST_OV_CFG_LN0_PWR_DOWN_OV);
37 core_set32(atcphy, ACIOPHY_TOP_BIST_CIOPHY_CFG1,
38 ACIOPHY_TOP_BIST_CIOPHY_CFG1_CLK_EN);
39 core_set32(atcphy, ACIOPHY_TOP_BIST_CIOPHY_CFG1,
40 ACIOPHY_TOP_BIST_CIOPHY_CFG1_BIST_EN);
41 writel(0, atcphy->regs.core + ACIOPHY_TOP_BIST_CIOPHY_CFG1);
42
43 ret = readl_poll_timeout(atcphy->regs.core + ACIOPHY_TOP_PHY_STAT, reg,
44 (reg & ACIOPHY_TOP_PHY_STAT_LN0_UNK0), 10, 10000);
45 if (ret)
46 dev_warn(atcphy->dev,
47 "timed out waiting for ACIOPHY_TOP_PHY_STAT_LN0_UNK0\n");
48
49 ret = readl_poll_timeout(atcphy->regs.core + ACIOPHY_TOP_PHY_STAT, reg,
50 !(reg & ACIOPHY_TOP_PHY_STAT_LN0_UNK23), 10, 10000);
51 if (ret)
52 dev_warn(atcphy->dev,
53 "timed out waiting for ACIOPHY_TOP_PHY_STAT_LN0_UNK23\n");
54
55 atcphy_clear_nonselected_phy_reset(atcphy);
56
57 /* More BIST stuff (?) */
58 writel(0, atcphy->regs.core + ACIOPHY_TOP_BIST_OV_CFG);
59 core_set32(atcphy, ACIOPHY_TOP_BIST_CIOPHY_CFG1,
60 ACIOPHY_TOP_BIST_CIOPHY_CFG1_CLK_EN);
61 core_set32(atcphy, ACIOPHY_TOP_BIST_CIOPHY_CFG1,
62 ACIOPHY_TOP_BIST_CIOPHY_CFG1_BIST_EN);
63 }
64
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2 5/5] phy: apple: atc: Split generation-specific code
[not found] <20261122-t8122-phy-v2-5-8d5c8fdf31ba@chaosmail.tech>
2026-11-22 20:23 ` [PATCH v2 5/5] phy: apple: atc: Split generation-specific code kernel test robot
@ 2026-11-22 21:36 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-11-22 21:36 UTC (permalink / raw)
To: Sasha Finkelstein, Sven Peter, Janne Grunau, Vinod Koul,
Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: llvm, oe-kbuild-all, asahi, linux-arm-kernel, linux-phy,
devicetree, linux-kernel, Sasha Finkelstein
Hi Sasha,
kernel test robot noticed the following build errors:
[auto build test ERROR on 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4]
url: https://github.com/intel-lab-lkp/linux/commits/Sasha-Finkelstein/dt-bindings-phy-atcphy-Add-M3-series/20261122-132757
base: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
patch link: https://lore.kernel.org/r/20261122-t8122-phy-v2-5-8d5c8fdf31ba%40chaosmail.tech
patch subject: [PATCH v2 5/5] phy: apple: atc: Split generation-specific code
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20261123/202611230532.xXpnoRHP-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 2012344e5da8e03ea4b8283ecd6fad6e13f09d64)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261123/202611230532.xXpnoRHP-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611230532.xXpnoRHP-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/phy/apple/atc-t8103.c:33:7: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
33 | FIELD_PREP(ACIOPHY_TOP_BIST_PHY_CFG1_LN0_PWR_DOWN, 3));
| ^
drivers/phy/apple/atc-t8103.c:71:7: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
71 | FIELD_PREP(DPRX_PCLK_SELECT, 1));
| ^
drivers/phy/apple/atc-t8103.c:146:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
146 | FIELD_PREP(ACIOPHY_SLEEP_CTRL_TX_SMALL_OV, 3));
| ^
3 errors generated.
--
>> drivers/phy/apple/atc-t8122.c:78:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
78 | FIELD_PREP(ACIOPHY_BIST_MAC_USBPHY_CFG_OV1_LN0_PWR_DOWN_OV, 2),
| ^
drivers/phy/apple/atc-t8122.c:158:7: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
158 | FIELD_PREP(AUSPLL_APB_CMD_OVERRIDE_CMD, command) |
| ^
drivers/phy/apple/atc-t8122.c:173:7: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
173 | FIELD_PREP(DPTX_PCLK1_SELECT, 1) | FIELD_PREP(DPTX_PCLK2_SELECT, 1) |
| ^
drivers/phy/apple/atc-t8122.c:249:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
249 | FIELD_PREP(LN_LDOCLK1_VREG_ADJ, 12));
| ^
drivers/phy/apple/atc-t8122.c:307:25: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
307 | LN_VREF221_EN | FIELD_PREP(LN_VREF221_FILTER_ADJUST, 1));
| ^
5 errors generated.
vim +/FIELD_PREP +33 drivers/phy/apple/atc-t8103.c
11
12 static void atcphy_configure_pipehandler_usb3_host_t8103(struct apple_atcphy *atcphy)
13 {
14 int ret;
15 u32 reg;
16
17 core_set32(atcphy, ACIOPHY_TOP_BIST_PHY_CFG0,
18 ACIOPHY_TOP_BIST_PHY_CFG0_LN0_RESET_N);
19 core_set32(atcphy, ACIOPHY_TOP_BIST_OV_CFG, ACIOPHY_TOP_BIST_OV_CFG_LN0_RESET_N_OV);
20 ret = readl_poll_timeout(atcphy->regs.core + ACIOPHY_TOP_PHY_STAT, reg,
21 !(reg & ACIOPHY_TOP_PHY_STAT_LN0_UNK23), 10, 10000);
22 if (ret)
23 dev_warn(atcphy->dev,
24 "Timed out waiting for ACIOPHY_TOP_PHY_STAT_LN0_UNK23\n");
25
26 core_set32(atcphy, ACIOPHY_TOP_BIST_READ_CTRL,
27 ACIOPHY_TOP_BIST_READ_CTRL_LN0_PHY_STATUS_RE);
28 core_clear32(atcphy, ACIOPHY_TOP_BIST_READ_CTRL,
29 ACIOPHY_TOP_BIST_READ_CTRL_LN0_PHY_STATUS_RE);
30
31 core_mask32(atcphy, ACIOPHY_TOP_BIST_PHY_CFG1,
32 ACIOPHY_TOP_BIST_PHY_CFG1_LN0_PWR_DOWN,
> 33 FIELD_PREP(ACIOPHY_TOP_BIST_PHY_CFG1_LN0_PWR_DOWN, 3));
34
35 core_set32(atcphy, ACIOPHY_TOP_BIST_OV_CFG,
36 ACIOPHY_TOP_BIST_OV_CFG_LN0_PWR_DOWN_OV);
37 core_set32(atcphy, ACIOPHY_TOP_BIST_CIOPHY_CFG1,
38 ACIOPHY_TOP_BIST_CIOPHY_CFG1_CLK_EN);
39 core_set32(atcphy, ACIOPHY_TOP_BIST_CIOPHY_CFG1,
40 ACIOPHY_TOP_BIST_CIOPHY_CFG1_BIST_EN);
41 writel(0, atcphy->regs.core + ACIOPHY_TOP_BIST_CIOPHY_CFG1);
42
43 ret = readl_poll_timeout(atcphy->regs.core + ACIOPHY_TOP_PHY_STAT, reg,
44 (reg & ACIOPHY_TOP_PHY_STAT_LN0_UNK0), 10, 10000);
45 if (ret)
46 dev_warn(atcphy->dev,
47 "timed out waiting for ACIOPHY_TOP_PHY_STAT_LN0_UNK0\n");
48
49 ret = readl_poll_timeout(atcphy->regs.core + ACIOPHY_TOP_PHY_STAT, reg,
50 !(reg & ACIOPHY_TOP_PHY_STAT_LN0_UNK23), 10, 10000);
51 if (ret)
52 dev_warn(atcphy->dev,
53 "timed out waiting for ACIOPHY_TOP_PHY_STAT_LN0_UNK23\n");
54
55 atcphy_clear_nonselected_phy_reset(atcphy);
56
57 /* More BIST stuff (?) */
58 writel(0, atcphy->regs.core + ACIOPHY_TOP_BIST_OV_CFG);
59 core_set32(atcphy, ACIOPHY_TOP_BIST_CIOPHY_CFG1,
60 ACIOPHY_TOP_BIST_CIOPHY_CFG1_CLK_EN);
61 core_set32(atcphy, ACIOPHY_TOP_BIST_CIOPHY_CFG1,
62 ACIOPHY_TOP_BIST_CIOPHY_CFG1_BIST_EN);
63 }
64
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread