From: "Heiko Stübner" <heiko@sntech.de>
To: Elaine Zhang <zhangqing@rock-chips.com>, Cunhao Lu <1579567540@qq.com>
Cc: linux-clk <linux-clk@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
mfd <mfd@lists.linux.dev>,
linux-gpio <linux-gpio@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
linux-pm <linux-pm@vger.kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-stm32 <linux-stm32@st-md-mailman.stormreply.com>,
linux-phy <linux-phy@lists.infradead.org>,
linux-usb <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 07/27] clk: rockchip: Add RK3572 clock and reset support
Date: Thu, 22 Oct 2026 09:38:06 +0200 [thread overview]
Message-ID: <2117228.PIDvDuAF1L@diego> (raw)
In-Reply-To: <tencent_791C8CE4050020CEF9E536C9D3B4CA9C250A@qq.com>
Hi,
Am Donnerstag, 22. Oktober 2026, 08:09:02 Mitteleuropäische Sommerzeit schrieb Cunhao Lu:
> Hi Heiko,
>
> > As you didn't write this driver on your own and even kept the original
> > author, please also credit the original author in the commit itself.
> >
> > This can be done for example with something like
> > git commit --amend --author="Elaine Zhang <zhangqing@rock-chips.com>"
> > and in the commit also have both signed-offs-by, aka Elaine first
> > then yours below as the submitter, i.e. like
> >
> > +++++++++++
> > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> > [document what changes you did inside the brackets]
> > Signed-off-by: Cunhao Lu <1579567540@qq.com>
> > +++++++++++
> >
> > The same applies to all commits coming from the Rockchip vendor kernel.
>
> Thanks for pointing this out, and sorry for missing the commit authorship.
>
> I'll review all patches and add the original authors' names where necessary.
> However, because the BSP I received does not include Git commit history, I can
> only identify them from the names noted in the file headers.
Rockchip has published a development branch based on 6.12 on github [0] .
This includes this clock driver [1] and most likely all the other parts as well.
You can use this to cross-reference.
If there are multiple authors changing the rk3572-specific parts of a file,
please use the first patch author from that history for your patch, as we
don't want to replicate the development history from that vendor kernel
tree.
Thanks
Heiko
[0] https://github.com/rockchip-linux/kernel/tree/develop-6.12
[1] https://github.com/rockchip-linux/kernel/blob/develop-6.12/drivers/clk/rockchip/clk-rk3572.c
next prev parent reply other threads:[~2026-10-22 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261022-add-board-ok3572-c-v1-0-0b0fd85a31ee@qq.com>
[not found] ` <20261022-add-board-ok3572-c-v1-14-0b0fd85a31ee@qq.com>
[not found] ` <09c223e6-6872-4bb6-a915-870c3ee614cb@lunn.ch>
2026-10-22 6:03 ` [PATCH 14/27] dt-bindings: net: rockchip-dwmac: Add RK3572 Cunhao Lu
[not found] ` <20261022-add-board-ok3572-c-v1-7-0b0fd85a31ee@qq.com>
[not found] ` <2339330.72vocr9iq0@diego>
2026-10-22 6:09 ` [PATCH 07/27] clk: rockchip: Add RK3572 clock and reset support Cunhao Lu
2026-10-22 7:38 ` Heiko Stübner [this message]
2026-10-22 8:31 ` Cunhao Lu
[not found] ` <7fa26028-5c7c-4c5d-8cc5-3116b2e51cc0@rock-chips.com>
2026-10-22 6:37 ` [PATCH 00/27] rockchip: Add RK3572 and Forlinx OK3572-C support Cunhao Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2117228.PIDvDuAF1L@diego \
--to=heiko@sntech.de \
--cc=1579567540@qq.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox