Re: [PATCH 14/27] dt-bindings: net: rockchip-dwmac: Add RK3572

Re: [PATCH 14/27] dt-bindings: net: rockchip-dwmac: Add RK3572

[Cunhao Lu]

Hi Andrew,

> Since this is a new device, please don't allow tx_delay and rx_delay,
> which should be considered deprecated, replaced by
> rx-internal-delay-ps and tx-internal-delay-ps.

Thanks for the feedback. I ran a matrix test and found that rgmii-id had
lower packet loss. For v2, I'll use rgmii-id without the delay properties.

Best regards,
Cunhao

Re: [PATCH 07/27] clk: rockchip: Add RK3572 clock and reset support

[Cunhao Lu]

Hi Heiko,

> As you didn't write this driver on your own and even kept the original
> author, please also credit the original author in the commit itself.
>
> This can be done for example with something like
> git commit --amend --author="Elaine Zhang <zhangqing@rock-chips.com>"
> and in the commit also have both signed-offs-by, aka Elaine first
> then yours below as the submitter, i.e. like
>
> +++++++++++
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> [document what changes you did inside the brackets]
> Signed-off-by: Cunhao Lu <1579567540@qq.com>
> +++++++++++
>
> The same applies to all commits coming from the Rockchip vendor kernel.

Thanks for pointing this out, and sorry for missing the commit authorship.

I'll review all patches and add the original authors' names where necessary.
However, because the BSP I received does not include Git commit history, I can
only identify them from the names noted in the file headers.

Best regards,
Cunhao

Re: [PATCH 00/27] rockchip: Add RK3572 and Forlinx OK3572-C support

[Cunhao Lu]

Hi,

> Thanks for your patches. Typically, a series of this size covering SoC
> support should be split by subsystem，for instance, separate DT binding
> and driver patches for each subsystem，and only CC the relevant
> maintainers and mailing lists. The DTS patch can follow afterwards.

Thank you for the guidance. I apologize for the inconvenience. I'll split
v2 by subsystem.

Best regards,
Cunhao

Re: [PATCH 07/27] clk: rockchip: Add RK3572 clock and reset support

[Heiko Stübner]

Hi,

Am Donnerstag, 22. Oktober 2026, 08:09:02 Mitteleuropäische Sommerzeit schrieb Cunhao Lu:
> Hi Heiko,
> 
> > As you didn't write this driver on your own and even kept the original
> > author, please also credit the original author in the commit itself.
> >
> > This can be done for example with something like
> > git commit --amend --author="Elaine Zhang <zhangqing@rock-chips.com>"
> > and in the commit also have both signed-offs-by, aka Elaine first
> > then yours below as the submitter, i.e. like
> >
> > +++++++++++
> > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> > [document what changes you did inside the brackets]
> > Signed-off-by: Cunhao Lu <1579567540@qq.com>
> > +++++++++++
> >
> > The same applies to all commits coming from the Rockchip vendor kernel.
> 
> Thanks for pointing this out, and sorry for missing the commit authorship.
> 
> I'll review all patches and add the original authors' names where necessary.
> However, because the BSP I received does not include Git commit history, I can
> only identify them from the names noted in the file headers.

Rockchip has published a development branch based on 6.12 on github [0] .
This includes this clock driver [1] and most likely all the other parts as well.
You can use this to cross-reference.

If there are multiple authors changing the rk3572-specific parts of a file,
please use the first patch author from that history for your patch, as we
don't want to replicate the development history from that vendor kernel
tree.


Thanks
Heiko

[0] https://github.com/rockchip-linux/kernel/tree/develop-6.12
[1] https://github.com/rockchip-linux/kernel/blob/develop-6.12/drivers/clk/rockchip/clk-rk3572.c

Re: [PATCH 07/27] clk: rockchip: Add RK3572 clock and reset support

[Cunhao Lu]

Hi Heiko,

> Rockchip has published a development branch based on 6.12 on github [0] .
> This includes this clock driver [1] and most likely all the other parts as well.
> You can use this to cross-reference.
>
> If there are multiple authors changing the rk3572-specific parts of a file,
> please use the first patch author from that history for your patch, as we
> don't want to replicate the development history from that vendor kernel
> tree.

Thank you for the link and clarification.

I'll cross-reference the RK3572 changes with:
  rockchip-linux/kernel:develop-6.12

Best regards,
Cunhao