Re: [PATCH 03/12] dt-bindings: pinctrl: rockchip: Add RV1106 compatible

[Jonas Karlman <jonas@kwiboo.se>]

Hi Simon,

On 7/6/2026 9:57 PM, Simon Glass wrote:
> Add the compatible for the pin controller of the Rockchip RV1106 and
> its RV1103 package variant.

The RV1106/RV1103 has a dedicated GPIO IOC regs block for each GPIO
controller. Something that seem to be different compared to other
Rockchip pinctrl/gpio controllers.

I think we possible need to have a rockchip,ioc or similar added to each
gpio bank for this variant.

Address mapping for gpio controllers and ioc regs.

  GPIO0		FF380000	32KB
  GPIO1_IOC	FF388000	32KB
  [...]
  GPIO1		FF530000	32KB
  GPIO1_IOC	FF538000	32KB
  GPIO2		FF540000	32KB
  GPIO2_IOC	FF548000	32KB
  GPIO3		FF550000	32KB
  GPIO3_IOC	FF558000	32KB
  GPIO4		FF560000	32KB
  GPIO4_IOC	FF568000	32KB

I even made a note of this in my mainline U-Boot tree at [1]:

  FIXME: range overlap gpio2+, u-boot pinctrl driver
  fail pinconf of gpio2+ unless regmap cover all banks.

Something I simply ignored at the time when I played around booting my
RV1106/RV1103 boards using mainline U-Boot. However, this is something
that should be fixed in a proper way for mainline Linux.

[1] https://git.u-boot-project.org/u-boot/contributors/kwiboo/u-boot/-/blob/rk3562/arch/arm/dts/rv1106.dtsi#L130-137

Regards,
Jonas

> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
>  Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> index 9b3cbeb54fed..81747bb53056 100644
> --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> @@ -51,6 +51,7 @@ properties:
>        - rockchip,rk3576-pinctrl
>        - rockchip,rk3588-pinctrl
>        - rockchip,rv1103b-pinctrl
> +      - rockchip,rv1106-pinctrl
>        - rockchip,rv1108-pinctrl
>        - rockchip,rv1126-pinctrl
>