From: jernej.skrabec@siol.net (Jernej Škrabec)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode
Date: Mon, 31 Jul 2017 19:18:28 +0200 [thread overview]
Message-ID: <2215267.q3CNAWEAR3@jernej-laptop> (raw)
In-Reply-To: <CAGb2v66FAYtsp39+5Aj2oZfyo=O=R1GJ11w3-vmJOysezsvcYg@mail.gmail.com>
Hi Chen-Yu,
Dne ponedeljek, 31. julij 2017 ob 07:02:18 CEST je Chen-Yu Tsai napisal(a):
> On Mon, Jul 31, 2017 at 12:41 AM, Jernej Skrabec
>
> <jernej.skrabec@siol.net> wrote:
> > Currently ccu_frac_helper_set_rate() doesn't wait for a lock bit to be
> > set before returning. Because of that, unstable clock may be used.
> >
> > Add a wait for lock in the helper function.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
>
> Can you provide a Fixes: tag?
fixes: 89a3dfb78707 ("clk: sunxi-ng: Add fractional lib")
As we discussed on IRC, it is safe to call ccu_helper_wait_for_lock() even on
platforms where lock bit is not present, since it just returns without effect.
Regards,
Jernej
>
> Otherwise this looks good.
next prev parent reply other threads:[~2017-07-31 17:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 16:41 [PATCH 0/4] clk: sunxi-ng: Fix issues with fractional mode Jernej Skrabec
2017-07-30 16:41 ` [PATCH 1/4] clk: sunxi-ng: Fix fractional mode for N-M clocks Jernej Skrabec
2017-07-31 4:54 ` Chen-Yu Tsai
2017-07-30 16:41 ` [PATCH 2/4] clk: sunxi-ng: multiplier: Fix fractional mode Jernej Skrabec
2017-07-31 5:39 ` Chen-Yu Tsai
2017-07-30 16:41 ` [PATCH 3/4] clk: sunxi-ng: Make fractional helper less chatty Jernej Skrabec
2017-07-31 7:15 ` Chen-Yu Tsai
2017-07-30 16:41 ` [PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode Jernej Skrabec
2017-07-31 5:02 ` Chen-Yu Tsai
2017-07-31 17:18 ` Jernej Škrabec [this message]
2017-07-31 5:13 ` [PATCH 0/4] clk: sunxi-ng: Fix issues with " Chen-Yu Tsai
2017-07-31 16:50 ` [linux-sunxi] " Jernej Škrabec
2017-08-01 2:17 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2215267.q3CNAWEAR3@jernej-laptop \
--to=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox