Re: [PATCH] arm64: dts: allwinner: a527: cubie-a5e: Add LEDs

["Jernej Škrabec" <jernej.skrabec@gmail.com>]

Dne torek, 12. avgust 2025 ob 19:59:27 Srednjeevropski poletni čas je Chen-Yu Tsai napisal(a):
> From: Chen-Yu Tsai <wens@csie.org>
> 
> The Radxa Cubie A5E has a 3-color LED. The green and blue LEDs are wired
> to GPIO pins on the SoC, and the green one is lit by default to serve as
> a power indicator. The red LED is wired to the M.2 slot.
> 
> Add device nodes for the green and blue LEDs.
> 
> A default "heartbeat" trigger is set for the green power LED, though in
> practice it might be better if it were inverted, i.e. lit most of the
> time.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
>  .../dts/allwinner/sun55i-a527-cubie-a5e.dts   | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts b/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts
> index fce2b7d1ba3d..cb2a2b62a2b2 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts
> @@ -6,6 +6,7 @@
>  #include "sun55i-a523.dtsi"
>  
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>  
>  / {
>  	model = "Radxa Cubie A5E";
> @@ -28,6 +29,24 @@ ext_osc32k: ext-osc32k-clk {
>  		clock-output-names = "ext_osc32k";
>  	};
>  
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		power-led {
> +			function = LED_FUNCTION_POWER;
> +			color = <LED_COLOR_ID_GREEN>;
> +			gpios = <&r_pio 0 4 GPIO_ACTIVE_LOW>; /* PL4 */
> +			default-state = "on";
> +			linux,default-trigger = "heartbeat";
> +		};
> +
> +		use-led {
> +			function = LED_FUNCTION_ACTIVITY;
> +			color = <LED_COLOR_ID_BLUE>;
> +			gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */
> +		};
> +	};
> +
>  	reg_vcc5v: vcc5v {
>  		/* board wide 5V supply from the USB-C connector */
>  		compatible = "regulator-fixed";
>