* [PATCH] arm64: dts: allwinner: a527: cubie-a5e: Add LEDs
@ 2025-08-12 17:59 Chen-Yu Tsai
2025-08-12 18:09 ` Jernej Škrabec
2025-08-20 17:19 ` Chen-Yu Tsai
0 siblings, 2 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2025-08-12 17:59 UTC (permalink / raw)
To: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland
Cc: linux-sunxi, devicetree, Andre Przywara, linux-arm-kernel
From: Chen-Yu Tsai <wens@csie.org>
The Radxa Cubie A5E has a 3-color LED. The green and blue LEDs are wired
to GPIO pins on the SoC, and the green one is lit by default to serve as
a power indicator. The red LED is wired to the M.2 slot.
Add device nodes for the green and blue LEDs.
A default "heartbeat" trigger is set for the green power LED, though in
practice it might be better if it were inverted, i.e. lit most of the
time.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
.../dts/allwinner/sun55i-a527-cubie-a5e.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts b/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts
index fce2b7d1ba3d..cb2a2b62a2b2 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts
@@ -6,6 +6,7 @@
#include "sun55i-a523.dtsi"
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
/ {
model = "Radxa Cubie A5E";
@@ -28,6 +29,24 @@ ext_osc32k: ext-osc32k-clk {
clock-output-names = "ext_osc32k";
};
+ leds {
+ compatible = "gpio-leds";
+
+ power-led {
+ function = LED_FUNCTION_POWER;
+ color = <LED_COLOR_ID_GREEN>;
+ gpios = <&r_pio 0 4 GPIO_ACTIVE_LOW>; /* PL4 */
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
+
+ use-led {
+ function = LED_FUNCTION_ACTIVITY;
+ color = <LED_COLOR_ID_BLUE>;
+ gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */
+ };
+ };
+
reg_vcc5v: vcc5v {
/* board wide 5V supply from the USB-C connector */
compatible = "regulator-fixed";
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: allwinner: a527: cubie-a5e: Add LEDs
2025-08-12 17:59 [PATCH] arm64: dts: allwinner: a527: cubie-a5e: Add LEDs Chen-Yu Tsai
@ 2025-08-12 18:09 ` Jernej Škrabec
2025-08-20 17:19 ` Chen-Yu Tsai
1 sibling, 0 replies; 3+ messages in thread
From: Jernej Škrabec @ 2025-08-12 18:09 UTC (permalink / raw)
To: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Chen-Yu Tsai
Cc: linux-sunxi, devicetree, Andre Przywara, linux-arm-kernel
Dne torek, 12. avgust 2025 ob 19:59:27 Srednjeevropski poletni čas je Chen-Yu Tsai napisal(a):
> From: Chen-Yu Tsai <wens@csie.org>
>
> The Radxa Cubie A5E has a 3-color LED. The green and blue LEDs are wired
> to GPIO pins on the SoC, and the green one is lit by default to serve as
> a power indicator. The red LED is wired to the M.2 slot.
>
> Add device nodes for the green and blue LEDs.
>
> A default "heartbeat" trigger is set for the green power LED, though in
> practice it might be better if it were inverted, i.e. lit most of the
> time.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> .../dts/allwinner/sun55i-a527-cubie-a5e.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts b/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts
> index fce2b7d1ba3d..cb2a2b62a2b2 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts
> @@ -6,6 +6,7 @@
> #include "sun55i-a523.dtsi"
>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>
> / {
> model = "Radxa Cubie A5E";
> @@ -28,6 +29,24 @@ ext_osc32k: ext-osc32k-clk {
> clock-output-names = "ext_osc32k";
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + power-led {
> + function = LED_FUNCTION_POWER;
> + color = <LED_COLOR_ID_GREEN>;
> + gpios = <&r_pio 0 4 GPIO_ACTIVE_LOW>; /* PL4 */
> + default-state = "on";
> + linux,default-trigger = "heartbeat";
> + };
> +
> + use-led {
> + function = LED_FUNCTION_ACTIVITY;
> + color = <LED_COLOR_ID_BLUE>;
> + gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */
> + };
> + };
> +
> reg_vcc5v: vcc5v {
> /* board wide 5V supply from the USB-C connector */
> compatible = "regulator-fixed";
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: allwinner: a527: cubie-a5e: Add LEDs
2025-08-12 17:59 [PATCH] arm64: dts: allwinner: a527: cubie-a5e: Add LEDs Chen-Yu Tsai
2025-08-12 18:09 ` Jernej Škrabec
@ 2025-08-20 17:19 ` Chen-Yu Tsai
1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2025-08-20 17:19 UTC (permalink / raw)
To: Jernej Skrabec, Samuel Holland, Chen-Yu Tsai
Cc: linux-sunxi, devicetree, Andre Przywara, linux-arm-kernel
On Wed, 13 Aug 2025 01:59:27 +0800, Chen-Yu Tsai wrote:
> The Radxa Cubie A5E has a 3-color LED. The green and blue LEDs are wired
> to GPIO pins on the SoC, and the green one is lit by default to serve as
> a power indicator. The red LED is wired to the M.2 slot.
>
> Add device nodes for the green and blue LEDs.
>
> A default "heartbeat" trigger is set for the green power LED, though in
> practice it might be better if it were inverted, i.e. lit most of the
> time.
>
> [...]
Applied to sunxi/dt-for-6.18 in local tree, thanks!
[1/1] arm64: dts: allwinner: a527: cubie-a5e: Add LEDs
commit: 4184f0190792aea06553af963741a24cc9b47689
Best regards,
--
Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-20 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-12 17:59 [PATCH] arm64: dts: allwinner: a527: cubie-a5e: Add LEDs Chen-Yu Tsai
2025-08-12 18:09 ` Jernej Škrabec
2025-08-20 17:19 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox