From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: firmware: arm,scmi: Add support for syspower protocol
Date: Fri, 23 Dec 2022 12:22:34 +0100 [thread overview]
Message-ID: <23436455-098f-6e21-2330-d91158a591ad@kernel.org> (raw)
In-Reply-To: <Y6WE1zQAxYYn6Ahz@e120937-lin>
On 23/12/2022 11:37, Cristian Marussi wrote:
>>>
>>> + protocol@12:
>>> + type: object
>>> + properties:
>>> + reg:
>>> + const: 0x12
>>> +
>>
>> Why? It did not got lost, it's already covered by pattern. If you refer
>> to particular warning, please paste it in commit msg. Otherwise it looks
>> incorrect.
>>
>
> Yes indeed, but as a matter of fact it seemed to me that we used to add an
> entry and an example for all the currently published standard SCMI protocols,
> even though already covered by the patternProp (which covers also any
> custom-vendor protocol in the wild) and not sporting any additional
> custom properties (see protocol@18), but maybe this is just a unneeded wrong
> habit adding only cruft to the bindings.
>
> If you think it does not add any value I can happily drop this, or
> limiting the addition just to the example (and/or drop equally the unneeded
> protocol@18 node too in this case).
Duplicating the node (once in properties, second in patternProperties)
is not needed. I am also not sure what would be the point to add to the
example - example does not have to be complete DTS for all cases, but
illustrate the binding and allow is to test it.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-23 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 18:38 [PATCH 0/5] Miscellaneous SCMI fixes for v6.2 Cristian Marussi
2022-12-22 18:38 ` [PATCH 1/5] firmware: arm_scmi: Clear stale xfer->hdr.status Cristian Marussi
2022-12-22 18:38 ` [PATCH 2/5] firmware: arm_scmi: Harden shared memory access in fetch_response Cristian Marussi
2022-12-22 18:38 ` [PATCH 3/5] firmware: arm_scmi: Harden shared memory access in fetch_notification Cristian Marussi
2022-12-22 18:38 ` [PATCH 4/5] dt-bindings: firmware: arm,scmi: Add support for syspower protocol Cristian Marussi
2022-12-23 10:11 ` Krzysztof Kozlowski
2022-12-23 10:37 ` Cristian Marussi
2022-12-23 11:22 ` Krzysztof Kozlowski [this message]
2023-01-03 10:08 ` Cristian Marussi
2022-12-22 18:38 ` [PATCH 5/5] firmware: arm_scmi: Fix virtio channels cleanup on shutdown Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23436455-098f-6e21-2330-d91158a591ad@kernel.org \
--to=krzk@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox