[PATCH 0/2] drm: devm_drm_bridge_alloc() conversion and cleanup

[PATCH 0/2] drm: devm_drm_bridge_alloc() conversion and cleanup

[Cristian Ciocaltea]

Bridge drivers are expected to allocate their private data via
devm_drm_bridge_alloc(), which also initializes the embedded struct
drm_bridge, including its funcs pointer.  Most drivers were converted by
commit 9c399719cfb9 ("drm: convert many bridge drivers from
devm_kzalloc() to devm_drm_bridge_alloc() API"), but a couple of
leftovers remain.

The first patch converts the rk3066_hdmi driver, which still uses
devm_kzalloc().  The second one removes a redundant manual assignment of
the bridge funcs pointer in the lontium-lt8713sx driver, which already
uses devm_drm_bridge_alloc().

Both changes are trivial and have no functional impact.  The series is
based on the latest drm-misc-next.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
Cristian Ciocaltea (2):
      drm/rockchip: rk3066_hdmi: Convert to devm_drm_bridge_alloc() API
      drm/bridge: lontium-lt8713sx: Drop redundant bridge funcs assignment

 drivers/gpu/drm/bridge/lontium-lt8713sx.c | 1 -
 drivers/gpu/drm/rockchip/rk3066_hdmi.c    | 8 ++++----
 2 files changed, 4 insertions(+), 5 deletions(-)
---
base-commit: 37b346eab23aead52d17a8fa687056bfc651a416
change-id: 20261001-bridge-alloc-conv-f517f9b2521f

[PATCH 1/2] drm/rockchip: rk3066_hdmi: Convert to devm_drm_bridge_alloc() API

[Cristian Ciocaltea]

Bridge drivers are expected to use devm_drm_bridge_alloc() instead of
devm_kzalloc() for allocating and partially initializing a private
driver struct embedding a struct drm_bridge.

Perform the API conversion and drop the now redundant manual
initialization of the drm_bridge funcs pointer, following the pattern
established by commit 9c399719cfb9 ("drm: convert many bridge drivers
from devm_kzalloc() to devm_drm_bridge_alloc() API").

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 drivers/gpu/drm/rockchip/rk3066_hdmi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
index f28d6a883e09..39c65ee07caa 100644
--- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c
+++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
@@ -703,7 +703,6 @@ rk3066_hdmi_register(struct drm_device *drm, struct rk3066_hdmi *hdmi)
 			 DRM_MODE_ENCODER_TMDS, NULL);
 
 	hdmi->bridge.driver_private = hdmi;
-	hdmi->bridge.funcs = &rk3066_hdmi_bridge_funcs;
 	hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT |
 			   DRM_BRIDGE_OP_EDID |
 			   DRM_BRIDGE_OP_HDMI |
@@ -747,9 +746,10 @@ static int rk3066_hdmi_bind(struct device *dev, struct device *master,
 	int irq;
 	int ret;
 
-	hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL);
-	if (!hdmi)
-		return -ENOMEM;
+	hdmi = devm_drm_bridge_alloc(dev, struct rk3066_hdmi, bridge,
+				     &rk3066_hdmi_bridge_funcs);
+	if (IS_ERR(hdmi))
+		return PTR_ERR(hdmi);
 
 	hdmi->dev = dev;
 	hdmi->drm_dev = drm;

-- 
2.55.0

Re: [PATCH 1/2] drm/rockchip: rk3066_hdmi: Convert to devm_drm_bridge_alloc() API

[Maxime Ripard]

On Thu, 1 Oct 2026 11:25:11 +0300, Cristian Ciocaltea wrote:
> Bridge drivers are expected to use devm_drm_bridge_alloc() instead of
> devm_kzalloc() for allocating and partially initializing a private
> driver struct embedding a struct drm_bridge.
> 
> Perform the API conversion and drop the now redundant manual
> 
> [ ... ]

Acked-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime

Re: [PATCH 1/2] drm/rockchip: rk3066_hdmi: Convert to devm_drm_bridge_alloc() API

[Luca Ceresoli]

On Thu Oct 1, 2026 at 10:25 AM CEST, Cristian Ciocaltea wrote:
> Bridge drivers are expected to use devm_drm_bridge_alloc() instead of
> devm_kzalloc() for allocating and partially initializing a private
> driver struct embedding a struct drm_bridge.
>
> Perform the API conversion and drop the now redundant manual
> initialization of the drm_bridge funcs pointer, following the pattern
> established by commit 9c399719cfb9 ("drm: convert many bridge drivers
> from devm_kzalloc() to devm_drm_bridge_alloc() API").
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH 2/2] drm/bridge: lontium-lt8713sx: Drop redundant bridge funcs assignment

[Cristian Ciocaltea]

The driver already allocates its private data via
devm_drm_bridge_alloc(), which initializes the bridge funcs pointer.
Remove the leftover manual assignment in the probe function.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 drivers/gpu/drm/bridge/lontium-lt8713sx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt8713sx.c b/drivers/gpu/drm/bridge/lontium-lt8713sx.c
index 926f9e1e85bf..18696b75bec1 100644
--- a/drivers/gpu/drm/bridge/lontium-lt8713sx.c
+++ b/drivers/gpu/drm/bridge/lontium-lt8713sx.c
@@ -554,7 +554,6 @@ static int lt8713sx_probe(struct i2c_client *client)
 
 	lt8713sx_reset(lt8713sx);
 
-	lt8713sx->bridge.funcs = &lt8713sx_bridge_funcs;
 	lt8713sx->bridge.of_node = dev->of_node;
 	lt8713sx->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;
 	drm_bridge_add(&lt8713sx->bridge);

-- 
2.55.0

Re: [PATCH 2/2] drm/bridge: lontium-lt8713sx: Drop redundant bridge funcs assignment

[Maxime Ripard]

On Thu, 1 Oct 2026 11:25:12 +0300, Cristian Ciocaltea wrote:
> The driver already allocates its private data via
> devm_drm_bridge_alloc(), which initializes the bridge funcs pointer.
> Remove the leftover manual assignment in the probe function.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> 
> [ ... ]

Acked-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime

Re: [PATCH 2/2] drm/bridge: lontium-lt8713sx: Drop redundant bridge funcs assignment

[Luca Ceresoli]

On Thu Oct 1, 2026 at 10:25 AM CEST, Cristian Ciocaltea wrote:
> The driver already allocates its private data via
> devm_drm_bridge_alloc(), which initializes the bridge funcs pointer.
> Remove the leftover manual assignment in the probe function.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

Well spotted!

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 0/2] drm: devm_drm_bridge_alloc() conversion and cleanup

[Luca Ceresoli]

On Thu, 01 Oct 2026 11:25:10 +0300, Cristian Ciocaltea wrote:
> Bridge drivers are expected to allocate their private data via
> devm_drm_bridge_alloc(), which also initializes the embedded struct
> drm_bridge, including its funcs pointer.  Most drivers were converted by
> commit 9c399719cfb9 ("drm: convert many bridge drivers from
> devm_kzalloc() to devm_drm_bridge_alloc() API"), but a couple of
> leftovers remain.
> 
> [...]

Applied, thanks!

[1/2] drm/rockchip: rk3066_hdmi: Convert to devm_drm_bridge_alloc() API
      commit: 5c0cdbee4fa4a621f871d6dc825e759db08a1a4a
[2/2] drm/bridge: lontium-lt8713sx: Drop redundant bridge funcs assignment
      commit: 382c1e8ba409d1611cd256dccebdfa828c832bb1

Best regards,
-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 0/2] drm: devm_drm_bridge_alloc() conversion and cleanup

[Johan Jonker]

Hi,

If any decency or Code of Conduct left in the DRM group then also credit the original author.
Also remove driver_private.

Johan

===

[PATCH v3] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API
https://lore.kernel.org/linux-rockchip/20260904-drm-v3-1-5b36532a3b72@gmail.com/  

[PATCH v2] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API
https://lore.kernel.org/linux-rockchip/20260824-drm-v2-1-7f9273c6020b@gmail.com/

https://lore.kernel.org/linux-rockchip/dea8a038-577b-45da-bff3-703e9099b7e1@gmail.com/
[PATCH v1] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API

On 10/16/26 08:52, Luca Ceresoli wrote:
> 
> On Thu, 01 Oct 2026 11:25:10 +0300, Cristian Ciocaltea wrote:
>> Bridge drivers are expected to allocate their private data via
>> devm_drm_bridge_alloc(), which also initializes the embedded struct
>> drm_bridge, including its funcs pointer.  Most drivers were converted by
>> commit 9c399719cfb9 ("drm: convert many bridge drivers from
>> devm_kzalloc() to devm_drm_bridge_alloc() API"), but a couple of
>> leftovers remain.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/2] drm/rockchip: rk3066_hdmi: Convert to devm_drm_bridge_alloc() API
>       commit: 5c0cdbee4fa4a621f871d6dc825e759db08a1a4a
> [2/2] drm/bridge: lontium-lt8713sx: Drop redundant bridge funcs assignment
>       commit: 382c1e8ba409d1611cd256dccebdfa828c832bb1
> 
> Best regards,

Re: [PATCH 0/2] drm: devm_drm_bridge_alloc() conversion and cleanup

[Cristian Ciocaltea]

Hi Johan,

On 10/16/26 11:11 AM, Johan Jonker wrote:
> Hi,
> 
> If any decency or Code of Conduct left in the DRM group then also credit the original author.

Sadly I wasn't aware of the indicated submission - this was just an unfortunate
overlap.  My series stems from the following discussion:

https://lore.kernel.org/all/743283af-753a-40bb-96f3-d05b1e38e186@collabora.com/

Regards,
Cristian

Re: [PATCH 0/2] drm: devm_drm_bridge_alloc() conversion and cleanup

[Luca Ceresoli]

Hello Johan,

On Fri Oct 16, 2026 at 10:11 AM CEST, Johan Jonker wrote:
> Hi,
>
> If any decency or Code of Conduct left in the DRM group then also credit the original author.

I'm sorry your prior patch was not applied. I was not in Cc I just hadn't
seen it, and no one else had reviewed or applied it so far.

This is a communication issue, sometimes patches just fall into the cracks
(it happened to mine several times). This can easily happen with a complex
development workflow and high amount of patches as DRM has. The workflow
can be possibly improved, as well as my personal workflow perhaps.

But I don't see any lack of decency here. Definitely a polite and
respectful answer would be appreciated and would help the communication.

> Also remove driver_private.

Removing driver_private where it is unused would be good. Would you mind
sending a patch doing that? I'll try to spot it, but if I'm in Cc it will
be much easier.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 0/2] drm: devm_drm_bridge_alloc() conversion and cleanup

[Heiko Stübner]

Hi Johan,

Am Freitag, 16. Oktober 2026, 10:11:19 Mitteleuropäische Sommerzeit schrieb Johan Jonker:
> If any decency or Code of Conduct left in the DRM group then also credit the original author.
> Also remove driver_private.

after letting that stew in my mind over a lunch break:

- yes, your patch was earlier
- yes, I should've gotten around to it earlier - I am sorry about that
- so yes, this got mishandled

Nevertheless, this in no way justifies attacking the "drm-group", which
consists of a big number of individuals (most of which had no contact with
either variant of the patch at all) on a personal level :-( .

The change itself of moving to devm_drm_bridge_alloc, also is somewhat
straight-forward  that two different people could easily just create the
same change separately, as we saw here.


Heiko


> ===
> 
> [PATCH v3] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API
> https://lore.kernel.org/linux-rockchip/20260904-drm-v3-1-5b36532a3b72@gmail.com/  
> 
> [PATCH v2] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API
> https://lore.kernel.org/linux-rockchip/20260824-drm-v2-1-7f9273c6020b@gmail.com/
> 
> https://lore.kernel.org/linux-rockchip/dea8a038-577b-45da-bff3-703e9099b7e1@gmail.com/
> [PATCH v1] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API
> 
> On 10/16/26 08:52, Luca Ceresoli wrote:
> > 
> > On Thu, 01 Oct 2026 11:25:10 +0300, Cristian Ciocaltea wrote:
> >> Bridge drivers are expected to allocate their private data via
> >> devm_drm_bridge_alloc(), which also initializes the embedded struct
> >> drm_bridge, including its funcs pointer.  Most drivers were converted by
> >> commit 9c399719cfb9 ("drm: convert many bridge drivers from
> >> devm_kzalloc() to devm_drm_bridge_alloc() API"), but a couple of
> >> leftovers remain.
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> > [1/2] drm/rockchip: rk3066_hdmi: Convert to devm_drm_bridge_alloc() API
> >       commit: 5c0cdbee4fa4a621f871d6dc825e759db08a1a4a
> > [2/2] drm/bridge: lontium-lt8713sx: Drop redundant bridge funcs assignment
> >       commit: 382c1e8ba409d1611cd256dccebdfa828c832bb1
> > 
> > Best regards,
> 
>