From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shreeya Patel <shreeya.patel@collabora.com>,
heiko@sntech.de, mchehab@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
p.zabel@pengutronix.de, jose.abreu@synopsys.com,
nelson.costa@synopsys.com, dmitry.osipenko@collabora.com,
sebastian.reichel@collabora.com, shawn.wen@rock-chips.com
Cc: kernel@collabora.com, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org,
linux-dt@vger.kernel.org, linux-arm@lists.infradead.org
Subject: Re: [PATCH 1/4] clk: rockchip: rst-rk3588: Add BIU reset
Date: Fri, 16 Feb 2024 11:03:04 +0100 [thread overview]
Message-ID: <237e690a-2f49-4046-b054-3a878eed6748@linaro.org> (raw)
In-Reply-To: <20240216094922.257674-2-shreeya.patel@collabora.com>
On 16/02/2024 10:49, Shreeya Patel wrote:
> Export hdmirx_biu soft reset id which is required by the hdmirx controller.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> ---
> drivers/clk/rockchip/rst-rk3588.c | 1 +
> include/dt-bindings/reset/rockchip,rk3588-cru.h | 2 ++
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
Please do internal review. The internal Collabora review would tell you:
YOU MUST run checkpatch. Then you see errors, so why do you send patch
with errors to the mailing list?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-16 10:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 9:49 [PATCH 0/4] Add Synopsys DesignWare HDMI RX Controller Shreeya Patel
2024-02-16 9:49 ` [PATCH 1/4] clk: rockchip: rst-rk3588: Add BIU reset Shreeya Patel
2024-02-16 10:03 ` Krzysztof Kozlowski [this message]
2024-02-16 12:48 ` Shreeya Patel
2024-02-17 8:17 ` Krzysztof Kozlowski
2024-02-17 10:18 ` Shreeya Patel
2024-02-17 10:20 ` Krzysztof Kozlowski
2024-02-17 10:36 ` Shreeya Patel
2024-02-16 19:29 ` Nicolas Dufresne
2024-02-16 9:49 ` [PATCH 2/4] dt-bindings: media: Document bindings for HDMI RX Controller Shreeya Patel
2024-02-16 10:01 ` Krzysztof Kozlowski
2024-02-21 20:55 ` Shreeya Patel
2024-02-22 8:30 ` Krzysztof Kozlowski
2024-02-16 11:30 ` Rob Herring
2024-02-16 9:49 ` [PATCH 3/4] arm64: dts: rockchip: Add device tree support " Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237e690a-2f49-4046-b054-3a878eed6748@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=heiko@sntech.de \
--cc=jose.abreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-dt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nelson.costa@synopsys.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.wen@rock-chips.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox