From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shreeya Patel <shreeya.patel@collabora.com>
Cc: heiko@sntech.de, mchehab@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
p.zabel@pengutronix.de, jose.abreu@synopsys.com,
nelson.costa@synopsys.com, dmitry.osipenko@collabora.com,
sebastian.reichel@collabora.com, shawn.wen@rock-chips.com,
kernel@collabora.com, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org,
linux-dt@vger.kernel.org, linux-arm@lists.infradead.org
Subject: Re: [PATCH 2/4] dt-bindings: media: Document bindings for HDMI RX Controller
Date: Thu, 22 Feb 2024 09:30:16 +0100 [thread overview]
Message-ID: <efee9c66-cb84-4f02-91b6-53f2db874b3b@linaro.org> (raw)
In-Reply-To: <1048c3-65d66380-b-49a25c80@188726434>
On 21/02/2024 21:55, Shreeya Patel wrote:
>>> + - hdmirx-5v-detection-gpios
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/clock/rockchip,rk3588-cru.h>
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> + #include <dt-bindings/interrupt-controller/irq.h>
>>> + #include <dt-bindings/power/rk3588-power.h>
>>> + #include <dt-bindings/reset/rockchip,rk3588-cru.h>
>>> + hdmirx_ctrler: hdmirx-controller@fdee0000 {
>>
>> What is hdmirx-controller? Isn't this just hdmi@?
>>
>
> Writing just hdmi would imply hdmi output I think so that name
> will not be appropriate here.
>
>> Node names should be generic. See also an explanation and list of
>> examples (not exhaustive) in DT specification:
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>>
>
> This documentation doesn't have any generic name for HDMI INPUT
> but maybe we can use the name hdmi-receiver like some other existing
> binding has it here :-
> Documentation/devicetree/bindings/media/i2c/tda1997x.txt
Yes, it is fine. You did not respond to other comments, so I assume you
agree with them.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-22 8:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 9:49 [PATCH 0/4] Add Synopsys DesignWare HDMI RX Controller Shreeya Patel
2024-02-16 9:49 ` [PATCH 1/4] clk: rockchip: rst-rk3588: Add BIU reset Shreeya Patel
2024-02-16 10:03 ` Krzysztof Kozlowski
2024-02-16 12:48 ` Shreeya Patel
2024-02-17 8:17 ` Krzysztof Kozlowski
2024-02-17 10:18 ` Shreeya Patel
2024-02-17 10:20 ` Krzysztof Kozlowski
2024-02-17 10:36 ` Shreeya Patel
2024-02-16 19:29 ` Nicolas Dufresne
2024-02-16 9:49 ` [PATCH 2/4] dt-bindings: media: Document bindings for HDMI RX Controller Shreeya Patel
2024-02-16 10:01 ` Krzysztof Kozlowski
2024-02-21 20:55 ` Shreeya Patel
2024-02-22 8:30 ` Krzysztof Kozlowski [this message]
2024-02-16 11:30 ` Rob Herring
2024-02-16 9:49 ` [PATCH 3/4] arm64: dts: rockchip: Add device tree support " Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efee9c66-cb84-4f02-91b6-53f2db874b3b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=heiko@sntech.de \
--cc=jose.abreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-dt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nelson.costa@synopsys.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.wen@rock-chips.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox