From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
frank.li@nxp.com, Sherry Sun <sherry.sun@nxp.com>
Cc: devicetree@vger.kernel.org, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart
Date: Tue, 02 Dec 2025 12:48:15 +0100 [thread overview]
Message-ID: <2395053.ElGaqSPkdT@steina-w> (raw)
In-Reply-To: <20251202111638.3553-1-sherry.sun@nxp.com>
Hi,
Am Dienstag, 2. Dezember 2025, 12:16:38 CET schrieb Sherry Sun:
> The commit 616effc0272b5 ("arm64: dts: imx8: Fix lpuart DMA channel
> order") swap uart rx and tx channel at common imx8-ss-dma.dtsi. But miss
> update imx8qm-ss-dma.dtsi.
>
> The commit 5a8e9b022e569 ("arm64: dts: imx8qm-ss-dma: Pass lpuart
> dma-names") just simple add dma-names as binding doc requirement.
>
> Correct lpuart0 - lpuart3 dma rx and tx channels, and use defines for
> the FSL_EDMA_RX flag.
>
> Fixes: 616effc0272b5 ("arm64: dts: imx8: Fix lpuart DMA channel order")
I'm wondering if this is actually a fix for 5a8e9b022e569 ("arm64: dts:
imx8qm-ss-dma: Pass lpuart dma-names") instead. 616effc0272b5 just
focuses on the common parts. But I don't have a strong opinion here.
Thanks and best regards,
Alexander
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> index 5f24850bf322..974e193f8dcb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> @@ -172,25 +172,25 @@ &flexcan3 {
>
> &lpuart0 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 13 0 0>, <&edma2 12 0 1>;
> + dmas = <&edma2 12 0 FSL_EDMA_RX>, <&edma2 13 0 0>;
> dma-names = "rx","tx";
> };
>
> &lpuart1 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 15 0 0>, <&edma2 14 0 1>;
> + dmas = <&edma2 14 0 FSL_EDMA_RX>, <&edma2 15 0 0>;
> dma-names = "rx","tx";
> };
>
> &lpuart2 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 17 0 0>, <&edma2 16 0 1>;
> + dmas = <&edma2 16 0 FSL_EDMA_RX>, <&edma2 17 0 0>;
> dma-names = "rx","tx";
> };
>
> &lpuart3 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 19 0 0>, <&edma2 18 0 1>;
> + dmas = <&edma2 18 0 FSL_EDMA_RX>, <&edma2 19 0 0>;
> dma-names = "rx","tx";
> };
>
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2025-12-02 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 11:16 [PATCH] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart Sherry Sun
2025-12-02 11:48 ` Alexander Stein [this message]
2025-12-02 14:48 ` Frank Li
2025-12-03 1:48 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2395053.ElGaqSPkdT@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox