Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	wens@csie.org, samuel@sholland.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: allwinner: h6: Add OrangePi 3 LTS DTS
Date: Tue, 29 Apr 2025 17:45:24 +0200	[thread overview]
Message-ID: <2486dae4-c5a5-4df2-8048-87b4b2d46d54@lunn.ch> (raw)
In-Reply-To: <4975791.GXAFRqVoOG@jernej-laptop>

> I just to be clear, I tested various combinations, including rgmii-id, and it
> didn't work, except rgmii-rxid, which matches strapping. Of course Motorcomm
> PHY driver took that into account and set registers accordingly.

So we have:

&emac {
	pinctrl-names = "default";
	pinctrl-0 = <&ext_rgmii_pins>;
	phy-mode = "rgmii-rxid";
	phy-handle = <&ext_rgmii_phy>;
	phy-supply = <&reg_gmac_3v3>;
	allwinner,rx-delay-ps = <0>;
	allwinner,tx-delay-ps = <700>;
	status = "okay";
};

and

&mdio {
	ext_rgmii_phy: ethernet-phy@1 {
		compatible = "ethernet-phy-ieee802.3-c22";
		reg = <1>;

		motorcomm,clk-out-frequency-hz = <125000000>;

		reset-gpios = <&pio 3 14 GPIO_ACTIVE_LOW>; /* PD14 */
		reset-assert-us = <15000>;
		reset-deassert-us = <100000>;
	};
};

The RX path looks O.K. RGMII-RXID means the PHY should be adding the
2ns delay. The allwinner,rx-delay-ps = <0> should be redundant, that
should be the driver default. And there are no properties in the PHY
node about RX. All good.

TX is the problem. The allwinner,tx-delay-ps = <700> causes the MAC to
add 700ps delay, and 'rgmii-rxid' means the PHY should not add any
delay. But 700ps is too low. It should be around 2000ps. So something
else is adding a delay, or the 700ps is not really 700ps.

You say the PHY is a YT8531C. These PHYs also accept
rx-internal-delay-ps and tx-internal-delay-ps properties in their DT
node.

Try setting 'rgmii-id', allwinner,tx-delay-ps = <0>, and both
rx-internal-delay-ps and tx-internal-delay-ps in the PHY node to 1950.
If that does not work, try other values in the PHY node.

	Andrew


  reply	other threads:[~2025-04-29 16:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-13 13:42 [PATCH 0/2] arm64: dts: allwinner: Support Orange Pi 3 LTS board Jernej Skrabec
2025-04-13 13:42 ` [PATCH 1/2] dt-bindings: arm: sunxi: Add " Jernej Skrabec
2025-04-15 21:56   ` Rob Herring (Arm)
2025-04-13 13:42 ` [PATCH 2/2] arm64: dts: allwinner: h6: Add OrangePi 3 LTS DTS Jernej Skrabec
2025-04-25  0:57   ` Andre Przywara
2025-04-25 12:54   ` Andre Przywara
2025-04-25 14:37     ` Chen-Yu Tsai
2025-04-25 15:34     ` Andrew Lunn
2025-04-26 18:00       ` Jernej Škrabec
2025-04-28 12:37         ` Andrew Lunn
2025-04-29 14:51           ` Jernej Škrabec
2025-04-29 15:09             ` Andrew Lunn
2025-04-29 15:24               ` Jernej Škrabec
2025-04-29 15:27                 ` Jernej Škrabec
2025-04-29 15:45                   ` Andrew Lunn [this message]
2025-04-29 15:52                     ` Chen-Yu Tsai
2025-04-29 16:56                       ` Andrew Lunn
2025-04-26 18:26     ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2486dae4-c5a5-4df2-8048-87b4b2d46d54@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox