From: Andrew Lunn <andrew@lunn.ch>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
wens@csie.org, samuel@sholland.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: allwinner: h6: Add OrangePi 3 LTS DTS
Date: Fri, 25 Apr 2025 17:34:14 +0200 [thread overview]
Message-ID: <cd7fd026-2f82-43d1-abdb-482bfe600bb5@lunn.ch> (raw)
In-Reply-To: <20250425135429.174a1871@donnerap.manchester.arm.com>
> > +&emac {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&ext_rgmii_pins>;
> > + phy-mode = "rgmii-rxid";
>
> So relating to what Andrew said earlier today, should this read rgmii-id
> instead? Since the strap resistors just set some boot-up value, but we
> want the PHY driver to enable both RX and TX delay programmatically?
Yes.
There is a checkpatch.pl patch working its way through the system
which will add warning about any rgmii value other than rgmii-id. Such
values need a comment that the PCB has extra long clock
lines. Hopefully that will make people actually stop and think about
this, rather than just copy broken vendor code.
Andrew
next prev parent reply other threads:[~2025-04-25 16:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-13 13:42 [PATCH 0/2] arm64: dts: allwinner: Support Orange Pi 3 LTS board Jernej Skrabec
2025-04-13 13:42 ` [PATCH 1/2] dt-bindings: arm: sunxi: Add " Jernej Skrabec
2025-04-15 21:56 ` Rob Herring (Arm)
2025-04-13 13:42 ` [PATCH 2/2] arm64: dts: allwinner: h6: Add OrangePi 3 LTS DTS Jernej Skrabec
2025-04-25 0:57 ` Andre Przywara
2025-04-25 12:54 ` Andre Przywara
2025-04-25 14:37 ` Chen-Yu Tsai
2025-04-25 15:34 ` Andrew Lunn [this message]
2025-04-26 18:00 ` Jernej Škrabec
2025-04-28 12:37 ` Andrew Lunn
2025-04-29 14:51 ` Jernej Škrabec
2025-04-29 15:09 ` Andrew Lunn
2025-04-29 15:24 ` Jernej Škrabec
2025-04-29 15:27 ` Jernej Škrabec
2025-04-29 15:45 ` Andrew Lunn
2025-04-29 15:52 ` Chen-Yu Tsai
2025-04-29 16:56 ` Andrew Lunn
2025-04-26 18:26 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd7fd026-2f82-43d1-abdb-482bfe600bb5@lunn.ch \
--to=andrew@lunn.ch \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox