Re: [PATCH V2 00/22] ARM: dts: stm32: Repair AV96 board

From: Marek Vasut <marex@denx.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	Patrick Delaunay <patrick.delaunay@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 00/22] ARM: dts: stm32: Repair AV96 board
Date: Tue, 31 Mar 2020 17:51:04 +0200	[thread overview]
Message-ID: <2595fc00-e3f0-fe38-995a-b0028819e47a@denx.de> (raw)
In-Reply-To: <20200331140900.GC17755@Mani-XPS-13-9360>

On 3/31/20 4:09 PM, Manivannan Sadhasivam wrote:
> On Tue, Mar 31, 2020 at 03:44:52PM +0200, Marek Vasut wrote:
>> On 3/31/20 6:07 AM, Manivannan Sadhasivam wrote:
>>> Hi Marek,
>>
>> Hi,
>>
>>> Thanks for the series. 
>>>
>>> On Tue, Mar 31, 2020 at 02:56:39AM +0200, Marek Vasut wrote:
>>>> The AV96 board device tree is completely broken and does not match the
>>>> hardware. This series fixes it up.
>>>>
>>>
>>> Completely broken?
>>
>> The board didn't even boot.
>>
> 
> Hmm. I think you're using a new revision of AV96. I added the board support
> with an old version of it (might be an evaluation one). I don't have the delta
> or changeset so can't compare. Anyway, DH started selling new boards and I
> think the old ones were discontinued or not made available for purchase so we
> don't have to worry about breaking the old one.

I'm sure we can/should support both, lemme ask about this. The baseboard
I have is 588-200 (silkscreen next to barrel jack) and SoM 586-100.

>>> The patch submitted previously was an initial one and there
>>> were many interfaces not enabled. I agree that there are few _obvious_ things
>>> like SDMMC1/Ethernet pinmux, LED naming were wrong. This was due to the fact the
>>> board was on early bringup stage and I couldn't test Ethernet due to my setup
>>> issue at that time (yeah I know it is bad). Also, I don't get access to DHCOR
>>> schematics as well for things like PMIC. Do you have access to it?
>>
>> Yes, I do have access.
>>
>>> If possible can you share a link to that if available publicly?
>>
>> The SoM schematic is not available in public, no, sorry.
>>
> 
> Fine. Just wanted to verify the PMIC part. But I got the information from
> DH guy offline.

Yep, I saw that, good.

>>> I will test this series and also the uboot one on my board and give my
>>> Tested-by tag soon.
>>>
>>> Anyway, I think the patchset subject could be something like,
>>> "Improve AV96 support" :)
>>
>> I think if something doesn't work, "Repair" is the right word for it.
> 
> Right. Didn't know that it doesn't boot on newer boards. I do have one but
> haven't tried mainline kernel on it, just vendor image for some demos. But
> feel free to keep it as it is.

Do you have the Enpirion regulator on the SoM ? It's between the
STPMIC1A and the SPI NOR.

I'll be sending a V3 shortly (few hours), apply it on next/master if you
want to test:
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel