* [PATCH] irqchip/sun6i-r: Use NULL for chip_data
@ 2022-04-24 17:39 Samuel Holland
2022-04-24 19:50 ` Jernej Škrabec
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Holland @ 2022-04-24 17:39 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier
Cc: Samuel Holland, kernel test robot, Chen-Yu Tsai, Jernej Skrabec,
linux-arm-kernel, linux-kernel, linux-sunxi
sparse complains about using an integer as a NULL pointer.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/irqchip/irq-sun6i-r.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
index 4cd3e533740b..a01e44049415 100644
--- a/drivers/irqchip/irq-sun6i-r.c
+++ b/drivers/irqchip/irq-sun6i-r.c
@@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain *domain,
for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
if (hwirq == nmi_hwirq) {
irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
- &sun6i_r_intc_nmi_chip, 0);
+ &sun6i_r_intc_nmi_chip,
+ NULL);
irq_set_handler(virq, handle_fasteoi_ack_irq);
} else {
irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
- &sun6i_r_intc_wakeup_chip, 0);
+ &sun6i_r_intc_wakeup_chip,
+ NULL);
}
}
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irqchip/sun6i-r: Use NULL for chip_data
2022-04-24 17:39 [PATCH] irqchip/sun6i-r: Use NULL for chip_data Samuel Holland
@ 2022-04-24 19:50 ` Jernej Škrabec
0 siblings, 0 replies; 2+ messages in thread
From: Jernej Škrabec @ 2022-04-24 19:50 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Samuel Holland
Cc: Samuel Holland, kernel test robot, Chen-Yu Tsai, linux-arm-kernel,
linux-kernel, linux-sunxi
Dne nedelja, 24. april 2022 ob 19:39:51 CEST je Samuel Holland napisal(a):
> sparse complains about using an integer as a NULL pointer.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
>
> drivers/irqchip/irq-sun6i-r.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
> index 4cd3e533740b..a01e44049415 100644
> --- a/drivers/irqchip/irq-sun6i-r.c
> +++ b/drivers/irqchip/irq-sun6i-r.c
> @@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain
*domain,
> for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
> if (hwirq == nmi_hwirq) {
> irq_domain_set_hwirq_and_chip(domain, virq,
hwirq,
> -
&sun6i_r_intc_nmi_chip, 0);
> +
&sun6i_r_intc_nmi_chip,
> + NULL);
> irq_set_handler(virq,
handle_fasteoi_ack_irq);
> } else {
> irq_domain_set_hwirq_and_chip(domain, virq,
hwirq,
> -
&sun6i_r_intc_wakeup_chip, 0);
> +
&sun6i_r_intc_wakeup_chip,
> + NULL);
> }
> }
>
> --
> 2.35.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-24 19:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-24 17:39 [PATCH] irqchip/sun6i-r: Use NULL for chip_data Samuel Holland
2022-04-24 19:50 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox