From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: zx: fix building with CONFIG_THUMB2_KERNEL
Date: Thu, 21 May 2015 10:36:42 +0200 [thread overview]
Message-ID: <2771121.xOQTA4CzPC@wuerfel> (raw)
The newly added zx platform causes a build error when
CONFIG_THUMB2_KERNEL is enabled:
arch/arm/mach-zx/headsmp.S:16: Error: invalid immediate for address calculation (value = 0x00000004)
I'm assuming that the ROM code that is calling these entry
points runs in ARM mode, so there would be another problem
in the same file, and we can solve both problems at once
by adding a '.arm' statement that will make zx_resume_jump
and zx_secondary_startup both be built as ARM code.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Hi Jun,
This patch fixes a build error with mach-zx, but I don't know if it's
actually correct. Can you check if the machine correctly boots
with this patch enabled and CONFIG_THUMB2_KERNEL=y set in the .config?
diff --git a/arch/arm/mach-zx/headsmp.S b/arch/arm/mach-zx/headsmp.S
index c0fece0c3955..a1aa4028389f 100644
--- a/arch/arm/mach-zx/headsmp.S
+++ b/arch/arm/mach-zx/headsmp.S
@@ -10,6 +10,7 @@
#include <linux/linkage.h>
.align 3
+ .arm
/* It runs from physical address */
ENTRY(zx_resume_jump)
next reply other threads:[~2015-05-21 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 8:36 Arnd Bergmann [this message]
2015-05-21 13:04 ` [PATCH] ARM: zx: fix building with CONFIG_THUMB2_KERNEL Jun Nie
2015-05-22 14:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2771121.xOQTA4CzPC@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox