From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: zx: fix building with CONFIG_THUMB2_KERNEL
Date: Fri, 22 May 2015 16:46:38 +0200 [thread overview]
Message-ID: <29857847.dJSqWUUsqW@wuerfel> (raw)
In-Reply-To: <CABymUCP=unny8rORcm4ki-izCsaoWysUQ2gUtro0-T1RV3Ad-g@mail.gmail.com>
On Thursday 21 May 2015 21:04:34 Jun Nie wrote:
> 2015-05-21 16:36 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
> > The newly added zx platform causes a build error when
> > CONFIG_THUMB2_KERNEL is enabled:
> >
> > arch/arm/mach-zx/headsmp.S:16: Error: invalid immediate for address calculation (value = 0x00000004)
> >
> > I'm assuming that the ROM code that is calling these entry
> > points runs in ARM mode, so there would be another problem
> > in the same file, and we can solve both problems at once
> > by adding a '.arm' statement that will make zx_resume_jump
> > and zx_secondary_startup both be built as ARM code.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > Hi Jun,
> >
> > This patch fixes a build error with mach-zx, but I don't know if it's
> > actually correct. Can you check if the machine correctly boots
> > with this patch enabled and CONFIG_THUMB2_KERNEL=y set in the .config?
> >
> Arnd,
>
> I add CONFIG_THUMB2_KERNEL=y in defconfig and reproduce the build
> error. Your change does fix the bug and boot/cpu_hotplug works well.
> Thanks for your work!
>
Ok, thanks for testing, I've applied the patch to next/soc now.
Arnd
prev parent reply other threads:[~2015-05-22 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 8:36 [PATCH] ARM: zx: fix building with CONFIG_THUMB2_KERNEL Arnd Bergmann
2015-05-21 13:04 ` Jun Nie
2015-05-22 14:46 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29857847.dJSqWUUsqW@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox