* Re: [PATCH v2 19/20] clk: sp7021: switch to FIELD_PREP_WM16 macro
[not found] ` <175340605069.3513.18204498860033427106@lazor>
@ 2025-08-25 7:48 ` Nicolas Frattaroli
0 siblings, 0 replies; only message in thread
From: Nicolas Frattaroli @ 2025-08-25 7:48 UTC (permalink / raw)
To: Stephen Boyd
Cc: kernel, linux-kernel, linux-mmc, linux-arm-kernel, linux-rockchip,
linux-media, dri-devel, linux-phy, linux-sound, netdev,
linux-stm32, linux-pci, linux-pm, linux-clk, llvm
On Friday, 25 July 2025 03:14:10 Central European Summer Time Stephen Boyd wrote:
> Quoting Nicolas Frattaroli (2025-06-23 09:05:47)
> > The sp7021 clock driver has its own shifted high word mask macro,
> > similar to the ones many Rockchip drivers have.
> >
> > Remove it, and replace instances of it with hw_bitfield.h's
> > FIELD_PREP_WM16 macro, which does the same thing except in a common
> > macro that also does compile-time error checking.
> >
> > This was compile-tested with 32-bit ARM with Clang, no runtime tests
> > were performed as I lack the hardware. However, I verified that fix
> > commit 5c667d5a5a3e ("clk: sp7021: Adjust width of _m in HWM_FIELD_PREP()")
> > is not regressed. No warning is produced.
>
> Does it generate the same code before and after?
>
Yes, the generated machine code is exactly the same, at least with
clang, and I'll assume it'll be the same for gcc.
Kind regards,
Nicolas Frattaroli
^ permalink raw reply [flat|nested] only message in thread