public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] reset: hisilicon: add reset core
Date: Tue, 22 Nov 2016 10:41:12 +0100	[thread overview]
Message-ID: <2907606.qYBKeXi75W@wuerfel> (raw)
In-Reply-To: <0084ef53-c0e6-51e8-afa5-07264dfce529@linaro.org>

On Tuesday, November 22, 2016 5:22:42 PM CET zhangfei wrote:
> Hi, Arnd
> 
> On 2016?11?22? 16:45, Arnd Bergmann wrote:
> > On Tuesday, November 22, 2016 3:49:16 PM CET Zhangfei Gao wrote:
> >> @@ -1,8 +1,8 @@
> >>   obj-y += core.o
> >> -obj-y += hisilicon/
> >>   obj-$(CONFIG_ARCH_STI) += sti/
> >>   obj-$(CONFIG_RESET_ATH79) += reset-ath79.o
> >>   obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
> >> +obj-$(CONFIG_ARCH_HISI) += hisilicon/
> >>   obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
> >>   obj-$(CONFIG_RESET_MESON) += reset-meson.o
> >>   obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
> > Please leave the obj-y line, otherwise the COMPILE_TEST variant won't work.
> 
> COMPILE_TEST is added in drivers/reset/hisilicon/Kconfig
> like
> config COMMON_RESET_HI3660
>          tristate "Hi3660 Reset Driver"
>          depends on ARCH_HISI || COMPILE_TEST
> 
> The reason not using "obj-y" here is that reset.c will be compiled unconditionally.
> 
> drivers/reset/hisilicon/Makefile
> obj-y   += reset.o

Yes, that line has to change as well then, to only build it when one
of the hardware specific drivers is enabled.

	Arnd

  reply	other threads:[~2016-11-22  9:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22  7:49 [PATCH 0/6] add hisilicon reset Zhangfei Gao
2016-11-22  7:49 ` [PATCH 1/6] reset: hisilicon: add reset core Zhangfei Gao
2016-11-22  8:45   ` Arnd Bergmann
2016-11-22  9:22     ` zhangfei
2016-11-22  9:41       ` Arnd Bergmann [this message]
2016-11-22 10:22   ` Philipp Zabel
2016-11-22 10:22   ` Philipp Zabel
2016-11-22  7:49 ` [PATCH 2/6] dt-bindings: Document the hi3660 reset bindings Zhangfei Gao
2016-11-22  7:49 ` [PATCH 3/6] reset: hisilicon: add reset-hi3660 Zhangfei Gao
2016-11-22  8:50   ` Arnd Bergmann
2016-11-22  9:34     ` zhangfei
2016-11-22  9:42       ` Arnd Bergmann
2016-11-22 10:02         ` zhangfei
2016-11-22 10:22         ` Philipp Zabel
2016-11-23  8:02           ` zhangfei
2016-11-22  7:49 ` [PATCH 4/6] dt-bindings: change hi6220-reset.txt according to reset-hi6220.c Zhangfei Gao
2016-11-22  8:48   ` Arnd Bergmann
2016-11-23 23:06     ` Rob Herring
2016-11-24  0:41       ` zhangfei
2016-11-22  7:49 ` [PATCH 5/6] reset: hisilicon: Use new driver reset-hi6222 Zhangfei Gao
2016-11-22  8:49   ` Arnd Bergmann
2016-11-22  9:46     ` zhangfei
2016-11-22  9:55       ` Arnd Bergmann
2016-11-22  7:49 ` [PATCH 6/6] arm64: dts: hi6220: update reset node according to reset-hi6220.c Zhangfei Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2907606.qYBKeXi75W@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox