public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] reset: hisilicon: Use new driver reset-hi6222
Date: Tue, 22 Nov 2016 10:55:21 +0100	[thread overview]
Message-ID: <6136167.uxgaKz0PCj@wuerfel> (raw)
In-Reply-To: <0dcef3c7-7406-0728-5a18-c277bb8915ad@linaro.org>

On Tuesday, November 22, 2016 5:46:22 PM CET zhangfei wrote:
> On 2016?11?22? 16:49, Arnd Bergmann wrote:
> > On Tuesday, November 22, 2016 3:49:20 PM CET Zhangfei Gao wrote:
> >> -#define PERIPH_RSTDIS0_MMC0             0x000
> >> -#define PERIPH_RSTDIS0_MMC1             0x001
> >> -#define PERIPH_RSTDIS0_MMC2             0x002
> >> -#define PERIPH_RSTDIS0_NANDC            0x003
> >> -#define PERIPH_RSTDIS0_USBOTG_BUS       0x004
> >> -#define PERIPH_RSTDIS0_POR_PICOPHY      0x005
> >> -#define PERIPH_RSTDIS0_USBOTG           0x006
> >> -#define PERIPH_RSTDIS0_USBOTG_32K       0x007
> >> -#define PERIPH_RSTDIS1_HIFI             0x100
> >> -#define PERIPH_RSTDIS1_DIGACODEC        0x105
> >> +/* reset in sysctrl */
> >> +#define PERIPH_RSTDIS0_MMC0             0
> >> +#define PERIPH_RSTDIS0_MMC1             1
> >> +#define PERIPH_RSTDIS0_MMC2             2
> >> +#define PERIPH_RSTDIS0_NANDC            3
> >> +#define PERIPH_RSTDIS0_USBOTG_BUS       4
> >> +#define PERIPH_RSTDIS0_POR_PICOPHY      5
> >> +#define PERIPH_RSTDIS0_USBOTG           6
> >> +#define PERIPH_RSTDIS0_USBOTG_32K       7
> >> +#define PERIPH_RSTDIS1_HIFI             8
> > You can't redefined the binding here, this is part of the ABI.
> > You can however add new numbers as long as the old ones keep
> > working.
> The methods are different.
> The original define is offset | bit_shift, and driver has to parse 
> offset and bit shift.
> The new define is just index of array, which is defined in the reset-xxx.c

I understand that, what I mean is you have to find a way to let the new
driver still support the old binding, you can't change it.

	Arnd

  reply	other threads:[~2016-11-22  9:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22  7:49 [PATCH 0/6] add hisilicon reset Zhangfei Gao
2016-11-22  7:49 ` [PATCH 1/6] reset: hisilicon: add reset core Zhangfei Gao
2016-11-22  8:45   ` Arnd Bergmann
2016-11-22  9:22     ` zhangfei
2016-11-22  9:41       ` Arnd Bergmann
2016-11-22 10:22   ` Philipp Zabel
2016-11-22 10:22   ` Philipp Zabel
2016-11-22  7:49 ` [PATCH 2/6] dt-bindings: Document the hi3660 reset bindings Zhangfei Gao
2016-11-22  7:49 ` [PATCH 3/6] reset: hisilicon: add reset-hi3660 Zhangfei Gao
2016-11-22  8:50   ` Arnd Bergmann
2016-11-22  9:34     ` zhangfei
2016-11-22  9:42       ` Arnd Bergmann
2016-11-22 10:02         ` zhangfei
2016-11-22 10:22         ` Philipp Zabel
2016-11-23  8:02           ` zhangfei
2016-11-22  7:49 ` [PATCH 4/6] dt-bindings: change hi6220-reset.txt according to reset-hi6220.c Zhangfei Gao
2016-11-22  8:48   ` Arnd Bergmann
2016-11-23 23:06     ` Rob Herring
2016-11-24  0:41       ` zhangfei
2016-11-22  7:49 ` [PATCH 5/6] reset: hisilicon: Use new driver reset-hi6222 Zhangfei Gao
2016-11-22  8:49   ` Arnd Bergmann
2016-11-22  9:46     ` zhangfei
2016-11-22  9:55       ` Arnd Bergmann [this message]
2016-11-22  7:49 ` [PATCH 6/6] arm64: dts: hi6220: update reset node according to reset-hi6220.c Zhangfei Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6136167.uxgaKz0PCj@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox