Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: fix RealView EB SMSC ethernet version
@ 2016-09-08  9:30 Linus Walleij
  2016-09-08  9:34 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2016-09-08  9:30 UTC (permalink / raw)
  To: linux-arm-kernel

The ethernet version in the earlier RealView EB variants is
LAN91C111 and not LAN9118 according to ARM DUI 0303E
"RealView Emulation Baseboard User Guide" page 3-57.

Make sure that this is used for the base variant of the board.

As the DT bindings for LAN91C111 does not specify any power
supplies, these need to be deleted from the DTS file.

Fixes: 2440d29d2ae2 ("ARM: dts: realview: support all the RealView EB board variants")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ARM SoC people: please apply this directly with the second patch.
---
 arch/arm/boot/dts/arm-realview-eb.dtsi | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/arch/arm/boot/dts/arm-realview-eb.dtsi b/arch/arm/boot/dts/arm-realview-eb.dtsi
index 1c6a040218e3..22f6a4f201b7 100644
--- a/arch/arm/boot/dts/arm-realview-eb.dtsi
+++ b/arch/arm/boot/dts/arm-realview-eb.dtsi
@@ -51,14 +51,6 @@
 		regulator-boot-on;
         };
 
-	veth: fixedregulator at 0 {
-		compatible = "regulator-fixed";
-		regulator-name = "veth";
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-		regulator-boot-on;
-	};
-
 	xtal24mhz: xtal24mhz at 24M {
 		#clock-cells = <0>;
 		compatible = "fixed-clock";
@@ -134,16 +126,11 @@
 		bank-width = <4>;
 	};
 
-	/* SMSC 9118 ethernet with PHY and EEPROM */
+	/* SMSC LAN91C111 ethernet with PHY and EEPROM */
 	ethernet: ethernet at 4e000000 {
-		compatible = "smsc,lan9118", "smsc,lan9115";
+		compatible = "smsc,lan91c111";
 		reg = <0x4e000000 0x10000>;
-		phy-mode = "mii";
 		reg-io-width = <4>;
-		smsc,irq-active-high;
-		smsc,irq-push-pull;
-		vdd33a-supply = <&veth>;
-		vddvario-supply = <&veth>;
 	};
 
 	usb: usb at 4f000000 {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 1/2] ARM: dts: fix RealView EB SMSC ethernet version
  2016-09-08  9:30 [PATCH 1/2] ARM: dts: fix RealView EB SMSC ethernet version Linus Walleij
@ 2016-09-08  9:34 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2016-09-08  9:34 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday, September 8, 2016 11:30:32 AM CEST Linus Walleij wrote:
> -       /* SMSC 9118 ethernet with PHY and EEPROM */
> +       /* SMSC LAN91C111 ethernet with PHY and EEPROM */
>         ethernet: ethernet at 4e000000 {
> -               compatible = "smsc,lan9118", "smsc,lan9115";
> +               compatible = "smsc,lan91c111";
>                 reg = <0x4e000000 0x10000>;
> -               phy-mode = "mii";
>                 reg-io-width = <4>;

The reg-io-width here needs to be 6 or 7, it's a mask of the possible
access widths, and as Russell pointed out it has to include 16-bit
accesses at least, but probably 8-bit access should also be enabled.

	Arnd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-08  9:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-08  9:30 [PATCH 1/2] ARM: dts: fix RealView EB SMSC ethernet version Linus Walleij
2016-09-08  9:34 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox