* [PATCH] coresight: tnoc: Constify amba_id table
@ 2026-07-05 17:19 Krzysztof Kozlowski
2026-07-06 10:16 ` Leo Yan
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-05 17:19 UTC (permalink / raw)
To: Suzuki K Poulose, Mike Leach, James Clark, Leo Yan,
Alexander Shishkin, coresight, linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
Static 'struct amba_id' table is not modified so can be changed to const
for more safety.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
drivers/hwtracing/coresight/coresight-tnoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-tnoc.c b/drivers/hwtracing/coresight/coresight-tnoc.c
index 9e8de4323d28..929d316b4b36 100644
--- a/drivers/hwtracing/coresight/coresight-tnoc.c
+++ b/drivers/hwtracing/coresight/coresight-tnoc.c
@@ -255,7 +255,7 @@ static void trace_noc_remove(struct amba_device *adev)
coresight_trace_id_put_system_id(drvdata->atid);
}
-static struct amba_id trace_noc_ids[] = {
+static const struct amba_id trace_noc_ids[] = {
{
.id = 0x000f0c00,
.mask = 0x00ffff00,
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] coresight: tnoc: Constify amba_id table
@ 2026-07-05 17:24 Krzysztof Kozlowski
2026-07-05 17:30 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-05 17:24 UTC (permalink / raw)
To: Suzuki K Poulose, Mike Leach, James Clark, Leo Yan,
Alexander Shishkin, coresight, linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
Static 'struct amba_id' table is not modified so can be changed to const
for more safety.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
drivers/hwtracing/coresight/coresight-tnoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-tnoc.c b/drivers/hwtracing/coresight/coresight-tnoc.c
index 9e8de4323d28..929d316b4b36 100644
--- a/drivers/hwtracing/coresight/coresight-tnoc.c
+++ b/drivers/hwtracing/coresight/coresight-tnoc.c
@@ -255,7 +255,7 @@ static void trace_noc_remove(struct amba_device *adev)
coresight_trace_id_put_system_id(drvdata->atid);
}
-static struct amba_id trace_noc_ids[] = {
+static const struct amba_id trace_noc_ids[] = {
{
.id = 0x000f0c00,
.mask = 0x00ffff00,
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] coresight: tnoc: Constify amba_id table
2026-07-05 17:24 [PATCH] coresight: tnoc: Constify amba_id table Krzysztof Kozlowski
@ 2026-07-05 17:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-05 17:30 UTC (permalink / raw)
To: Suzuki K Poulose, Mike Leach, James Clark, Leo Yan,
Alexander Shishkin, coresight, linux-arm-kernel, linux-kernel
On 05/07/2026 19:24, Krzysztof Kozlowski wrote:
> Static 'struct amba_id' table is not modified so can be changed to const
> for more safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> drivers/hwtracing/coresight/coresight-tnoc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Apologies, duplicated posting, please ignore this one.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] coresight: tnoc: Constify amba_id table
2026-07-05 17:19 Krzysztof Kozlowski
@ 2026-07-06 10:16 ` Leo Yan
0 siblings, 0 replies; 4+ messages in thread
From: Leo Yan @ 2026-07-06 10:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Suzuki K Poulose, Mike Leach, James Clark, Alexander Shishkin,
coresight, linux-arm-kernel, linux-kernel
On Sun, Jul 05, 2026 at 07:19:35PM +0200, Krzysztof Kozlowski wrote:
> Static 'struct amba_id' table is not modified so can be changed to const
> for more safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Leo Yan <leo.yan@arm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-06 10:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-05 17:24 [PATCH] coresight: tnoc: Constify amba_id table Krzysztof Kozlowski
2026-07-05 17:30 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2026-07-05 17:19 Krzysztof Kozlowski
2026-07-06 10:16 ` Leo Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox