From: Krzysztof Kozlowski <krzk@kernel.org>
To: Conor Dooley <conor@kernel.org>, Macpaul Lin <macpaul.lin@mediatek.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Alexandre Mergnat <amergnat@baylibre.com>,
Flora Fu <flora.fu@mediatek.com>,
Bear Wang <bear.wang@mediatek.com>,
Pablo Sun <pablo.sun@mediatek.com>,
Macpaul Lin <macpaul@gmail.com>, Sen Chu <sen.chu@mediatek.com>,
Chris-qj chen <chris-qj.chen@mediatek.com>,
MediaTek Chromebook Upstream
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
Chen-Yu Tsai <wenst@chromium.org>
Subject: Re: [PATCH] dt-bindings: mfd: mediatek,mt6357: Fixup reference to pwrap node
Date: Mon, 26 Aug 2024 18:07:12 +0200 [thread overview]
Message-ID: <2e5513ec-2bfc-4ab0-9aee-7389e2194721@kernel.org> (raw)
In-Reply-To: <20240826-slurp-earphone-0d5173923ae8@spud>
On 26/08/2024 17:50, Conor Dooley wrote:
> On Mon, Aug 26, 2024 at 02:54:15PM +0800, Macpaul Lin wrote:
>> The mt6357 is a subnode of pwrap node. Previously, the documentation
>> only included a note in the description of mt6357. This change adds the
>> appropriate $ref for pwrap to ensure clarity and correctness.
>
> I think this change is wrong and the existing binding is fine.
> Adding the ref overcomplicates the binding completely, and stating that
> this is a child node of another device is sufficient.
>
> Instead, if anything, the pwrap binding should have a ref to /this/
> binding.
Yes or list allowed compatibles for child node.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-26 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 6:54 [PATCH] dt-bindings: mfd: mediatek,mt6357: Fixup reference to pwrap node Macpaul Lin
2024-08-26 15:45 ` Krzysztof Kozlowski
2024-08-26 15:50 ` Conor Dooley
2024-08-26 16:07 ` Krzysztof Kozlowski [this message]
2024-08-30 11:25 ` Macpaul Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e5513ec-2bfc-4ab0-9aee-7389e2194721@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bear.wang@mediatek.com \
--cc=chris-qj.chen@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=flora.fu@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=pablo.sun@mediatek.com \
--cc=robh@kernel.org \
--cc=sen.chu@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox