From: Macpaul Lin <macpaul.lin@mediatek.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Alexandre Mergnat <amergnat@baylibre.com>,
"Flora Fu" <flora.fu@mediatek.com>
Cc: Bear Wang <bear.wang@mediatek.com>,
Pablo Sun <pablo.sun@mediatek.com>,
Macpaul Lin <macpaul.lin@mediatek.com>,
Macpaul Lin <macpaul@gmail.com>, "Sen Chu" <sen.chu@mediatek.com>,
Chris-qj chen <chris-qj.chen@mediatek.com>,
MediaTek Chromebook Upstream
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, "Chen-Yu Tsai" <wenst@chromium.org>
Subject: [PATCH] dt-bindings: mfd: mediatek,mt6357: Fixup reference to pwrap node
Date: Mon, 26 Aug 2024 14:54:15 +0800 [thread overview]
Message-ID: <20240826065415.19641-1-macpaul.lin@mediatek.com> (raw)
The mt6357 is a subnode of pwrap node. Previously, the documentation
only included a note in the description of mt6357. This change adds the
appropriate $ref for pwrap to ensure clarity and correctness.
$ref: /schemas/soc/mediatek/mediatek,pwrap.yaml
Additionally, the indentation for the pmic section has been adjusted
to match the corresponding structure.
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
.../bindings/mfd/mediatek,mt6357.yaml | 124 +++++++++---------
1 file changed, 65 insertions(+), 59 deletions(-)
Changes for v1:
- This patch has been made based on linux-next/master branch.
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml
index b67fbe0..5f4f540 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml
@@ -22,69 +22,75 @@ description: |
It is interfaced to host controller using SPI interface by a proprietary hardware
called PMIC wrapper or pwrap. This MFD is a child device of pwrap.
- See the following for pwrap node definitions:
- Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
properties:
- compatible:
- const: mediatek,mt6357
-
- interrupts:
- maxItems: 1
-
- interrupt-controller: true
-
- "#interrupt-cells":
- const: 2
-
- mediatek,hp-pull-down:
- description:
- Earphone driver positive output stage short to
- the audio reference ground.
- type: boolean
-
- mediatek,micbias0-microvolt:
- description: Selects MIC Bias 0 output voltage.
- enum: [1700000, 1800000, 1900000, 2000000,
- 2100000, 2500000, 2600000, 2700000]
- default: 1700000
-
- mediatek,micbias1-microvolt:
- description: Selects MIC Bias 1 output voltage.
- enum: [1700000, 1800000, 1900000, 2000000,
- 2100000, 2500000, 2600000, 2700000]
- default: 1700000
-
- regulators:
- type: object
- $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml
- unevaluatedProperties: false
- description:
- List of MT6357 BUCKs and LDOs regulators.
-
- rtc:
+ pwrap:
type: object
- $ref: /schemas/rtc/rtc.yaml#
- unevaluatedProperties: false
- description:
- MT6357 Real Time Clock.
+ $ref: /schemas/soc/mediatek/mediatek,pwrap.yaml
properties:
- compatible:
- const: mediatek,mt6357-rtc
- start-year: true
- required:
- - compatible
-
- keys:
- type: object
- $ref: /schemas/input/mediatek,pmic-keys.yaml
- unevaluatedProperties: false
- description:
- MT6357 power and home keys.
-
-required:
- - compatible
- - regulators
+ pmic:
+ type: object
+ additionalProperties: false
+ properties:
+ compatible:
+ const: mediatek,mt6357
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+
+ mediatek,hp-pull-down:
+ description:
+ Earphone driver positive output stage short to
+ the audio reference ground.
+ type: boolean
+
+ mediatek,micbias0-microvolt:
+ description: Selects MIC Bias 0 output voltage.
+ enum: [1700000, 1800000, 1900000, 2000000,
+ 2100000, 2500000, 2600000, 2700000]
+ default: 1700000
+
+ mediatek,micbias1-microvolt:
+ description: Selects MIC Bias 1 output voltage.
+ enum: [1700000, 1800000, 1900000, 2000000,
+ 2100000, 2500000, 2600000, 2700000]
+ default: 1700000
+
+ regulators:
+ type: object
+ $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml
+ unevaluatedProperties: false
+ description:
+ List of MT6357 BUCKs and LDOs regulators.
+
+ rtc:
+ type: object
+ $ref: /schemas/rtc/rtc.yaml#
+ unevaluatedProperties: false
+ description:
+ MT6357 Real Time Clock.
+ properties:
+ compatible:
+ const: mediatek,mt6357-rtc
+ start-year: true
+ required:
+ - compatible
+
+ keys:
+ type: object
+ $ref: /schemas/input/mediatek,pmic-keys.yaml
+ unevaluatedProperties: false
+ description:
+ MT6357 power and home keys.
+
+ required:
+ - compatible
+ - regulators
additionalProperties: false
--
2.45.2
next reply other threads:[~2024-08-26 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 6:54 Macpaul Lin [this message]
2024-08-26 15:45 ` [PATCH] dt-bindings: mfd: mediatek,mt6357: Fixup reference to pwrap node Krzysztof Kozlowski
2024-08-26 15:50 ` Conor Dooley
2024-08-26 16:07 ` Krzysztof Kozlowski
2024-08-30 11:25 ` Macpaul Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826065415.19641-1-macpaul.lin@mediatek.com \
--to=macpaul.lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bear.wang@mediatek.com \
--cc=chris-qj.chen@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=flora.fu@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=pablo.sun@mediatek.com \
--cc=robh@kernel.org \
--cc=sen.chu@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox