Re: [RESEND][PATCH] arm: omap1: use string choices helper

[Janusz Krzysztofik <jmkrzyszt@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]

On Thursday, 7 August 2025 01:20:36 CEST Kuninori Morimoto wrote:
> We can use string choices helper, let's use it.
> 
> It updates format
> 
> -	..."%sabled", ...? "dis" : "en",
> +	..."%s",      ...  str_disabled_enabled(...)
> 	      ^^^^^
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>

Acked-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>

> ---
> KernelVersion: v6.17
> 
>  arch/arm/mach-omap1/board-ams-delta.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
> index 16392720296c..52681837ba4d 100644
> --- a/arch/arm/mach-omap1/board-ams-delta.c
> +++ b/arch/arm/mach-omap1/board-ams-delta.c
> @@ -759,8 +759,8 @@ static void modem_pm(struct uart_port *port, unsigned int state, unsigned old)
>  
>  	if (ret)
>  		dev_warn(port->dev,
> -			 "ams_delta modem_pm: failed to %sable regulator: %d\n",
> -			 state ? "dis" : "en", ret);
> +			 "ams_delta modem_pm: failed to %s regulator: %d\n",
> +			 str_disable_enable(state), ret);
>  }
>  
>  static struct plat_serial8250_port ams_delta_modem_ports[] = {
> 


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]