* [RESEND][PATCH] arm: omap1: use string choices helper
@ 2025-08-06 23:20 Kuninori Morimoto
2025-08-11 18:42 ` Janusz Krzysztofik
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2025-08-06 23:20 UTC (permalink / raw)
To: Aaro Koskinen, Janusz Krzysztofik, Russell King, Tony Lindgren,
linux-arm-kernel
Cc: patches
We can use string choices helper, let's use it.
It updates format
- ..."%sabled", ...? "dis" : "en",
+ ..."%s", ... str_disabled_enabled(...)
^^^^^
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
---
KernelVersion: v6.17
arch/arm/mach-omap1/board-ams-delta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
index 16392720296c..52681837ba4d 100644
--- a/arch/arm/mach-omap1/board-ams-delta.c
+++ b/arch/arm/mach-omap1/board-ams-delta.c
@@ -759,8 +759,8 @@ static void modem_pm(struct uart_port *port, unsigned int state, unsigned old)
if (ret)
dev_warn(port->dev,
- "ams_delta modem_pm: failed to %sable regulator: %d\n",
- state ? "dis" : "en", ret);
+ "ams_delta modem_pm: failed to %s regulator: %d\n",
+ str_disable_enable(state), ret);
}
static struct plat_serial8250_port ams_delta_modem_ports[] = {
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [RESEND][PATCH] arm: omap1: use string choices helper
2025-08-06 23:20 [RESEND][PATCH] arm: omap1: use string choices helper Kuninori Morimoto
@ 2025-08-11 18:42 ` Janusz Krzysztofik
0 siblings, 0 replies; 2+ messages in thread
From: Janusz Krzysztofik @ 2025-08-11 18:42 UTC (permalink / raw)
To: Aaro Koskinen, Russell King, Tony Lindgren, linux-arm-kernel,
Kuninori Morimoto
Cc: patches
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
On Thursday, 7 August 2025 01:20:36 CEST Kuninori Morimoto wrote:
> We can use string choices helper, let's use it.
>
> It updates format
>
> - ..."%sabled", ...? "dis" : "en",
> + ..."%s", ... str_disabled_enabled(...)
> ^^^^^
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
Acked-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> ---
> KernelVersion: v6.17
>
> arch/arm/mach-omap1/board-ams-delta.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
> index 16392720296c..52681837ba4d 100644
> --- a/arch/arm/mach-omap1/board-ams-delta.c
> +++ b/arch/arm/mach-omap1/board-ams-delta.c
> @@ -759,8 +759,8 @@ static void modem_pm(struct uart_port *port, unsigned int state, unsigned old)
>
> if (ret)
> dev_warn(port->dev,
> - "ams_delta modem_pm: failed to %sable regulator: %d\n",
> - state ? "dis" : "en", ret);
> + "ams_delta modem_pm: failed to %s regulator: %d\n",
> + str_disable_enable(state), ret);
> }
>
> static struct plat_serial8250_port ams_delta_modem_ports[] = {
>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-11 22:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-06 23:20 [RESEND][PATCH] arm: omap1: use string choices helper Kuninori Morimoto
2025-08-11 18:42 ` Janusz Krzysztofik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox