From: Shaokun Zhang <zhangshaokun@hisilicon.com>
To: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers/perf: arm_pmu: Show PMU version on boot
Date: Wed, 26 Aug 2020 14:42:26 +0800 [thread overview]
Message-ID: <31085eff-991a-4191-5629-930047eb10ea@hisilicon.com> (raw)
In-Reply-To: <20200821160304.GD21517@willie-the-truck>
Hi Will,
在 2020/8/22 0:03, Will Deacon 写道:
> On Thu, Jul 30, 2020 at 06:47:21PM +0800, Shaokun Zhang wrote:
>> The @pmuver field has been initialized and can tell the PMU version.
>> Let's show it on boot and the user obtains this information directly.
>>
>> Cc: Will Deacon <will@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>> ---
>> drivers/perf/arm_pmu.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
>> index df352b334ea7..36f7fad7ba5a 100644
>> --- a/drivers/perf/arm_pmu.c
>> +++ b/drivers/perf/arm_pmu.c
>> @@ -870,8 +870,8 @@ int armpmu_register(struct arm_pmu *pmu)
>> if (!__oprofile_cpu_pmu)
>> __oprofile_cpu_pmu = pmu;
>>
>> - pr_info("enabled with %s PMU driver, %d counters available\n",
>> - pmu->name, pmu->num_events);
>> + pr_info("enabled with %s PMU driver, %d counters available, version is %d\n",
>> + pmu->name, pmu->num_events, pmu->pmuver);
>
> Hmm. I'm suspicious about this. Who is using this, and what for? We're
Since Arm ARM has extended PMU version for Armv8.1/8.4/8.5 with different PMUver in
ID_AA64DFR0_EL1, someone who does the performance profiling may care the number of
counter and want to know the supported PMU version. Because some events or features
are related to PMU version, Like events corresponding to PMCEID0/1_EL0[32:63] or if
anyone be told PMMIR_EL1 to ZERO, he can check the PMU version directly from the boot
log information.
> better off exposing things in the existing sysfs directory we have if it's
> actually needed by tools.
If you agree it is needed, it is a good choice to do it.
Thanks,
Shaokun
>
> Will
>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-26 6:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:47 [PATCH] drivers/perf: arm_pmu: Show PMU version on boot Shaokun Zhang
2020-08-21 16:03 ` Will Deacon
2020-08-26 6:42 ` Shaokun Zhang [this message]
2020-09-01 16:16 ` Will Deacon
2020-09-02 1:31 ` Shaokun Zhang
2020-09-07 13:24 ` Will Deacon
2020-09-08 10:59 ` Shaokun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31085eff-991a-4191-5629-930047eb10ea@hisilicon.com \
--to=zhangshaokun@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox