From: Will Deacon <will@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers/perf: arm_pmu: Show PMU version on boot
Date: Fri, 21 Aug 2020 17:03:05 +0100 [thread overview]
Message-ID: <20200821160304.GD21517@willie-the-truck> (raw)
In-Reply-To: <1596106041-7688-1-git-send-email-zhangshaokun@hisilicon.com>
On Thu, Jul 30, 2020 at 06:47:21PM +0800, Shaokun Zhang wrote:
> The @pmuver field has been initialized and can tell the PMU version.
> Let's show it on boot and the user obtains this information directly.
>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/perf/arm_pmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index df352b334ea7..36f7fad7ba5a 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -870,8 +870,8 @@ int armpmu_register(struct arm_pmu *pmu)
> if (!__oprofile_cpu_pmu)
> __oprofile_cpu_pmu = pmu;
>
> - pr_info("enabled with %s PMU driver, %d counters available\n",
> - pmu->name, pmu->num_events);
> + pr_info("enabled with %s PMU driver, %d counters available, version is %d\n",
> + pmu->name, pmu->num_events, pmu->pmuver);
Hmm. I'm suspicious about this. Who is using this, and what for? We're
better off exposing things in the existing sysfs directory we have if it's
actually needed by tools.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-21 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:47 [PATCH] drivers/perf: arm_pmu: Show PMU version on boot Shaokun Zhang
2020-08-21 16:03 ` Will Deacon [this message]
2020-08-26 6:42 ` Shaokun Zhang
2020-09-01 16:16 ` Will Deacon
2020-09-02 1:31 ` Shaokun Zhang
2020-09-07 13:24 ` Will Deacon
2020-09-08 10:59 ` Shaokun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821160304.GD21517@willie-the-truck \
--to=will@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox