From: Andrew Lunn <andrew@lunn.ch>
To: Rosen Penev <rosenp@gmail.com>
Cc: devicetree@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"moderated list:ARM/Marvell Kirkwood and Armada 370, 375,
38x,..." <linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: helios4: add Wake-on-LAN gpio key
Date: Tue, 1 Sep 2026 21:38:03 +0200 [thread overview]
Message-ID: <3143f0d2-8990-4a75-b7c4-27edfc90ae54@lunn.ch> (raw)
In-Reply-To: <CAKxU2N_qR-KKvq=qv0eu4PMYMf8zHnpYnZ8jMvpBNKVitB3Vuw@mail.gmail.com>
On Tue, Sep 01, 2026 at 11:37:03AM -0700, Rosen Penev wrote:
> On Mon, Aug 31, 2026 at 8:08 PM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Mon, Aug 31, 2026 at 07:53:11PM -0700, Rosen Penev wrote:
> > > Add a gpio-keys node exposing Wake-On-LAN on its gpio0 18 input,
> > > allowing the board to be woken from suspend.
> >
> > Could you explain this some more. Why a GPIO key? The MAC needs to
> > know if the PHY can wake the system, in order to offload the WoL to
> > the PHY.
> This was an out of tree solution to get WOL working on this board.
>
> After some back and forth with an LLM, the conclusion reached was that
> this is the simplest way to get it working, not upstream ready. And as
> sashiko points out, it has problems. I'll respin.
Please do look at the work Russell King did for phylink and WoL.
What MAC and PHY are involved?
Andrew
prev parent reply other threads:[~2026-09-01 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 2:53 [PATCH] ARM: dts: helios4: add Wake-on-LAN gpio key Rosen Penev
2026-09-01 3:08 ` Andrew Lunn
2026-09-01 18:37 ` Rosen Penev
2026-09-01 19:38 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3143f0d2-8990-4a75-b7c4-27edfc90ae54@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox