[PATCH] ARM: dts: helios4: add Wake-on-LAN gpio key

[PATCH] ARM: dts: helios4: add Wake-on-LAN gpio key

[Rosen Penev]

Add a gpio-keys node exposing Wake-On-LAN on its gpio0 18 input,
allowing the board to be woken from suspend.

Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/arm/boot/dts/marvell/armada-388-helios4.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
index 176198d99c26..e3376c703cbf 100644
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
@@ -87,6 +87,18 @@ fault-led {
 		};
 	};
 
+	gpio-keys {
+		compatible = "gpio-keys";
+		pinctrl-0 = <&microsom_phy0_int_pins>;
+
+		wol {
+			label = "Wake-On-LAN";
+			linux,code = <KEY_WAKEUP>;
+			gpios = <&gpio0 18 GPIO_ACTIVE_LOW>;
+			wakeup-source;
+		};
+	};
+
 	io-leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
-- 
2.55.0

Re: [PATCH] ARM: dts: helios4: add Wake-on-LAN gpio key

[Andrew Lunn]

On Mon, Aug 31, 2026 at 07:53:11PM -0700, Rosen Penev wrote:
> Add a gpio-keys node exposing Wake-On-LAN on its gpio0 18 input,
> allowing the board to be woken from suspend.

Could you explain this some more. Why a GPIO key? The MAC needs to
know if the PHY can wake the system, in order to offload the WoL to
the PHY.

    Andrew

Re: [PATCH] ARM: dts: helios4: add Wake-on-LAN gpio key

[Rosen Penev]

On Mon, Aug 31, 2026 at 8:08 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, Aug 31, 2026 at 07:53:11PM -0700, Rosen Penev wrote:
> > Add a gpio-keys node exposing Wake-On-LAN on its gpio0 18 input,
> > allowing the board to be woken from suspend.
>
> Could you explain this some more. Why a GPIO key? The MAC needs to
> know if the PHY can wake the system, in order to offload the WoL to
> the PHY.
This was an out of tree solution to get WOL working on this board.

After some back and forth with an LLM, the conclusion reached was that
this is the simplest way to get it working, not upstream ready. And as
sashiko points out, it has problems. I'll respin.
>
>     Andrew

Re: [PATCH] ARM: dts: helios4: add Wake-on-LAN gpio key

[Andrew Lunn]

On Tue, Sep 01, 2026 at 11:37:03AM -0700, Rosen Penev wrote:
> On Mon, Aug 31, 2026 at 8:08 PM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Mon, Aug 31, 2026 at 07:53:11PM -0700, Rosen Penev wrote:
> > > Add a gpio-keys node exposing Wake-On-LAN on its gpio0 18 input,
> > > allowing the board to be woken from suspend.
> >
> > Could you explain this some more. Why a GPIO key? The MAC needs to
> > know if the PHY can wake the system, in order to offload the WoL to
> > the PHY.
> This was an out of tree solution to get WOL working on this board.
> 
> After some back and forth with an LLM, the conclusion reached was that
> this is the simplest way to get it working, not upstream ready. And as
> sashiko points out, it has problems. I'll respin.

Please do look at the work Russell King did for phylink and WoL.

What MAC and PHY are involved?

     Andrew