public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 0/15] don't export static symbol
@ 2015-03-11 16:56 Julia Lawall
  2015-03-11 16:56 ` [PATCH 14/15] ARM: cns3xxx: " Julia Lawall
  0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
  To: linux-arm-kernel

These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on
static functions.

This was done using the following semantic patch:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
type T;
identifier f;
@@

static T f (...) { ... }

@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@

-EXPORT_SYMBOL(f);

@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@

-EXPORT_SYMBOL_GPL(f);
// </smpl>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
  2015-03-11 16:56 [PATCH 0/15] don't export static symbol Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
  2015-03-11 21:09   ` Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
  To: linux-arm-kernel

From: Julia Lawall <Julia.Lawall@lip6.fr>

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
type T;
identifier f;
@@

static T f (...) { ... }

@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@

-EXPORT_SYMBOL(f);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 arch/arm/mach-cns3xxx/pm.c |    1 -
 1 file changed, 1 deletion(-)

diff -u -p a/arch/arm/mach-cns3xxx/pm.c b/arch/arm/mach-cns3xxx/pm.c
--- a/arch/arm/mach-cns3xxx/pm.c
+++ b/arch/arm/mach-cns3xxx/pm.c
@@ -73,7 +73,6 @@ static void cns3xxx_pwr_soft_rst_force(u
 
 	__raw_writel(reg, PM_SOFT_RST_REG);
 }
-EXPORT_SYMBOL(cns3xxx_pwr_soft_rst_force);
 
 void cns3xxx_pwr_soft_rst(unsigned int block)
 {

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
  2015-03-11 16:56 ` [PATCH 14/15] ARM: cns3xxx: " Julia Lawall
@ 2015-03-11 21:09   ` Arnd Bergmann
  2015-03-13  5:59     ` Krzysztof Hałasa
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2015-03-11 21:09 UTC (permalink / raw)
  To: linux-arm-kernel

On Wednesday 11 March 2015 17:56:36 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
> 
> -EXPORT_SYMBOL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 

Looks good. Krzysztof, do you want to pick this up and send me a
pull request together with other patches, or should I apply this
to the arm-soc fixes directly?

	Arnd

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
  2015-03-11 21:09   ` Arnd Bergmann
@ 2015-03-13  5:59     ` Krzysztof Hałasa
  2015-03-13 10:04       ` Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Hałasa @ 2015-03-13  5:59 UTC (permalink / raw)
  To: linux-arm-kernel

Arnd Bergmann <arnd@arndb.de> writes:

> Looks good. Krzysztof, do you want to pick this up and send me a
> pull request together with other patches, or should I apply this
> to the arm-soc fixes directly?

The latter, please.
Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
-- 
Krzysztof Halasa

Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
  2015-03-13  5:59     ` Krzysztof Hałasa
@ 2015-03-13 10:04       ` Arnd Bergmann
  0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2015-03-13 10:04 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 13 March 2015 06:59:38 Krzysztof Ha?asa wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> 
> > Looks good. Krzysztof, do you want to pick this up and send me a
> > pull request together with other patches, or should I apply this
> > to the arm-soc fixes directly?
> 
> The latter, please.
> Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
> -- 

Applied to next/fixes-non-critical with your Ack, thanks!

	Arnd

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-03-13 10:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-11 16:56 [PATCH 0/15] don't export static symbol Julia Lawall
2015-03-11 16:56 ` [PATCH 14/15] ARM: cns3xxx: " Julia Lawall
2015-03-11 21:09   ` Arnd Bergmann
2015-03-13  5:59     ` Krzysztof Hałasa
2015-03-13 10:04       ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox