* [PATCH v2 1/1] drm: lcdif: Use dev_err_probe()
@ 2025-10-20 9:58 Alexander Stein
2025-10-20 15:50 ` Frank Li
2025-11-13 10:47 ` Alexander Stein
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2025-10-20 9:58 UTC (permalink / raw)
To: Marek Vasut, Stefan Agner, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Alexander Stein, dri-devel, imx, linux-arm-kernel, linux-kernel,
Liu Ying, Marco Felsch
Use dev_err_probe() to add a reason for deferred probe. This can
especially happen on lcdif3 which uses hdmi_tx_phy for 'pix' clock
Reviewed-by: Liu Ying <victor.liu@nxp.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v2:
* Collected Liu's and Marcos' R-b
drivers/gpu/drm/mxsfb/lcdif_drv.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c
index fcb2a7517377e..47da1d9336b90 100644
--- a/drivers/gpu/drm/mxsfb/lcdif_drv.c
+++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c
@@ -149,15 +149,17 @@ static int lcdif_load(struct drm_device *drm)
lcdif->clk = devm_clk_get(drm->dev, "pix");
if (IS_ERR(lcdif->clk))
- return PTR_ERR(lcdif->clk);
+ return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk), "Failed to get pix clock\n");
lcdif->clk_axi = devm_clk_get(drm->dev, "axi");
if (IS_ERR(lcdif->clk_axi))
- return PTR_ERR(lcdif->clk_axi);
+ return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_axi),
+ "Failed to get axi clock\n");
lcdif->clk_disp_axi = devm_clk_get(drm->dev, "disp_axi");
if (IS_ERR(lcdif->clk_disp_axi))
- return PTR_ERR(lcdif->clk_disp_axi);
+ return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_disp_axi),
+ "Failed to get disp_axi clock\n");
platform_set_drvdata(pdev, drm);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] drm: lcdif: Use dev_err_probe()
2025-10-20 9:58 [PATCH v2 1/1] drm: lcdif: Use dev_err_probe() Alexander Stein
@ 2025-10-20 15:50 ` Frank Li
2025-11-13 10:47 ` Alexander Stein
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2025-10-20 15:50 UTC (permalink / raw)
To: Alexander Stein
Cc: Marek Vasut, Stefan Agner, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, dri-devel,
imx, linux-arm-kernel, linux-kernel, Liu Ying, Marco Felsch
On Mon, Oct 20, 2025 at 11:58:45AM +0200, Alexander Stein wrote:
> Use dev_err_probe() to add a reason for deferred probe. This can
> especially happen on lcdif3 which uses hdmi_tx_phy for 'pix' clock
>
> Reviewed-by: Liu Ying <victor.liu@nxp.com>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Collected Liu's and Marcos' R-b
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> drivers/gpu/drm/mxsfb/lcdif_drv.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c
> index fcb2a7517377e..47da1d9336b90 100644
> --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c
> +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c
> @@ -149,15 +149,17 @@ static int lcdif_load(struct drm_device *drm)
>
> lcdif->clk = devm_clk_get(drm->dev, "pix");
> if (IS_ERR(lcdif->clk))
> - return PTR_ERR(lcdif->clk);
> + return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk), "Failed to get pix clock\n");
>
> lcdif->clk_axi = devm_clk_get(drm->dev, "axi");
> if (IS_ERR(lcdif->clk_axi))
> - return PTR_ERR(lcdif->clk_axi);
> + return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_axi),
> + "Failed to get axi clock\n");
>
> lcdif->clk_disp_axi = devm_clk_get(drm->dev, "disp_axi");
> if (IS_ERR(lcdif->clk_disp_axi))
> - return PTR_ERR(lcdif->clk_disp_axi);
> + return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_disp_axi),
> + "Failed to get disp_axi clock\n");
>
> platform_set_drvdata(pdev, drm);
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] drm: lcdif: Use dev_err_probe()
2025-10-20 9:58 [PATCH v2 1/1] drm: lcdif: Use dev_err_probe() Alexander Stein
2025-10-20 15:50 ` Frank Li
@ 2025-11-13 10:47 ` Alexander Stein
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2025-11-13 10:47 UTC (permalink / raw)
To: Marek Vasut, Stefan Agner, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: dri-devel, imx, linux-arm-kernel, linux-kernel, Liu Ying,
Marco Felsch
Hi,
Am Montag, 20. Oktober 2025, 11:58:45 CET schrieb Alexander Stein:
> Use dev_err_probe() to add a reason for deferred probe. This can
> especially happen on lcdif3 which uses hdmi_tx_phy for 'pix' clock
>
> Reviewed-by: Liu Ying <victor.liu@nxp.com>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Any other feedback?
Thanks and best regards
Alexander
> ---
> Changes in v2:
> * Collected Liu's and Marcos' R-b
>
> drivers/gpu/drm/mxsfb/lcdif_drv.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c
> index fcb2a7517377e..47da1d9336b90 100644
> --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c
> +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c
> @@ -149,15 +149,17 @@ static int lcdif_load(struct drm_device *drm)
>
> lcdif->clk = devm_clk_get(drm->dev, "pix");
> if (IS_ERR(lcdif->clk))
> - return PTR_ERR(lcdif->clk);
> + return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk), "Failed to get pix clock\n");
>
> lcdif->clk_axi = devm_clk_get(drm->dev, "axi");
> if (IS_ERR(lcdif->clk_axi))
> - return PTR_ERR(lcdif->clk_axi);
> + return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_axi),
> + "Failed to get axi clock\n");
>
> lcdif->clk_disp_axi = devm_clk_get(drm->dev, "disp_axi");
> if (IS_ERR(lcdif->clk_disp_axi))
> - return PTR_ERR(lcdif->clk_disp_axi);
> + return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_disp_axi),
> + "Failed to get disp_axi clock\n");
>
> platform_set_drvdata(pdev, drm);
>
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-13 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-20 9:58 [PATCH v2 1/1] drm: lcdif: Use dev_err_probe() Alexander Stein
2025-10-20 15:50 ` Frank Li
2025-11-13 10:47 ` Alexander Stein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox